-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Raise error if waved cannot find public/private dir #2130 #2213
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @92ammarraza! A small refactor needed and should be good to go.
Hey @92ammarraza. Make sure the comments are addressed in the correct branch. File changes view doesn't show your latest changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure you test your code and it works correctly. It does not at the moment. An err is thrown even for valid directories.
The PR fulfills these requirements: (check all the apply)
main
branch.feat: Add a button #xxx
, where "xxx" is the issue number).Closes #xxx
, where "xxx" is the issue number.ui
folder, unit tests (make test
) still pass.Related issue #2130
Overview:
This pull request addresses the issue #2130 , where waved would start without error even if the specified public/private directories were missing or incorrectly configured. The changes introduce error checking during server startup to ensure these directories exist and are accessible.
Changes:
checkDirectory
function inserver.go
to validate the existence of public and private directories.Testing
Closes #2130