Fixes Igalia#1494

Add a Fullscreen item in the hamburger menu to set the current window in the fullscreen mode. This item will not be available in kiosk mode.
haanhvu · Nov 18, 2024 · 9f55776 · 9f55776
1 parent 86abf88
commit 9f55776
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 0 deletions.
diff --git a/app/src/common/shared/com/igalia/wolvic/ui/widgets/NavigationBarWidget.java b/app/src/common/shared/com/igalia/wolvic/ui/widgets/NavigationBarWidget.java
@@ -1347,6 +1347,11 @@ public void onResize() {
                 enterResizeMode();
             }
 
+            @Override
+            public void onFullScreen() {
+                mAttachedWindow.setIsFullScreen(true);
+            }
+
             @Override
             public void onPassthrough() {
                 mWidgetManager.togglePassthrough();

diff --git a/app/src/common/shared/com/igalia/wolvic/ui/widgets/menus/HamburgerMenuWidget.java b/app/src/common/shared/com/igalia/wolvic/ui/widgets/menus/HamburgerMenuWidget.java
@@ -55,6 +55,7 @@ public interface MenuDelegate {
         void onPageZoomIn();
         void onPageZoomOut();
         int getCurrentZoomLevel();
+        void onFullScreen();
     }
 
     public static final int SWITCH_ITEM_ID = 0;
@@ -189,6 +190,18 @@ private void updateItems() {
 
         // In kiosk mode, only resize, find in page and passthrough are available.
         if (!mWidgetManager.getFocusedWindow().isKioskMode()) {
+            mItems.add(new HamburgerMenuAdapter.MenuItem.Builder(
+                    HamburgerMenuAdapter.MenuItem.TYPE_DEFAULT,
+                    (menuItem) -> {
+                        if (mDelegate != null) {
+                            mDelegate.onFullScreen();
+                        }
+                        return null;
+                    })
+                    .withTitle(getContext().getString(R.string.hamburger_menu_fullscreen))
+                    .withIcon(R.drawable.fullscreen_button)
+                    .build());
+
             final Session activeSession = SessionStore.get().getActiveSession();
 
             if (!BuildConfig.FLAVOR_backend.equals("chromium")) {

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -2074,6 +2074,10 @@ the Select` button. When clicked it bookmarks all the previously selected tabs -
          it saves the Web App provided by the current page -->
     <string name="hamburger_menu_save_web_app">Save Web app…</string>
 
+    <!-- This string is displayed inside the Hamburger menu at the right of the navigation bar. When clicked
+         it put the current window in fullscreen mode -->
+    <string name="hamburger_menu_fullscreen">Fullscreen</string>
+
     <!-- This string is displayed in the tooltip that is displayed when the user hovers the hamburger menu icon -->
     <string name="hamburger_menu_tooltip">Menu</string>