Adds exports for oauth signup URL. #1122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chefsalim
reviewed
Jul 12, 2019
baumanj
reviewed
Jul 12, 2019
Signed-off-by: Ian Henry <[email protected]>
|
Looking at this more, I'm not actually sure we need any of these changes... this is only an issue for the on-premises installation/configuration - for SaaS and dev environments, we will not need to change the sign-in config, as those environments are not meant for arbitrary OAuth configuration. |
chefsalim
reviewed
Jul 15, 2019
| @@ -15,6 +15,7 @@ provider = "github" | |||
| token_url = "https://github.com/login/oauth/access_token" | |||
| userinfo_url = "https://api.github.com/user" | |||
| redirect_url = "" | |||
| signup_url = "" | |||
There was a problem hiding this comment.
Don't think we need this
raskchanky
approved these changes
Jul 15, 2019
|
Indeed i believed initially we needed this as plumbing for the on-prem services to be able to configure themselves appropriately but I no longer believe that to be the case. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help to push the oauth signup url from our deployment config and should help to resolve habitat-sh/on-prem-builder#131 in tandem with habitat-sh/on-prem-builder#161
Signed-off-by: Ian Henry [email protected]