Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RHTAPBUGS-1019): add support for staged index use case #69

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

scoheb
Copy link
Contributor

@scoheb scoheb commented Nov 27, 2023

  • set parameters accordingly when stagedIndex = true.
  • we want to force opt_in to false and ensure no images are overwritten or published

Related to konflux-ci/release-service-catalog#305

happybhati
happybhati previously approved these changes Nov 27, 2023
@mmalina
Copy link
Contributor

mmalina commented Nov 28, 2023

Requires redhat-appstudio/release-service-catalog#305

Since the new param is optional and has a default, this doesn't really require the other one. It's rather the opposite - this one is needed by 305, right? It's a detail, but I was both of them saying they require the other which seemed odd.

@scoheb
Copy link
Contributor Author

scoheb commented Nov 28, 2023

Requires redhat-appstudio/release-service-catalog#305

Since the new param is optional and has a default, this doesn't really require the other one. It's rather the opposite - this one is needed by 305, right? It's a detail, but I was both of them saying they require the other which seemed odd.

worded incorrectly...maybe relates to...

- set parameters accordingly when stagedIndex = true.
- we want to force opt_in to false and ensure no images
  are overwritten or published

Signed-off-by: Scott Hebert <[email protected]>
@scoheb scoheb force-pushed the improve-staged-index-support branch from 8ecb92a to 873249c Compare November 28, 2023 13:21
@scoheb scoheb merged commit 38d0022 into hacbs-release:main Nov 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants