feat: Add character page #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gracewzhang
requested changes
Feb 10, 2023
| @@ -0,0 +1,3575 @@ | |||
| # THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | |||
There was a problem hiding this comment.
It'd be great if we could avoid including this!
There was a problem hiding this comment.
I believe it is actually good practice to include the yarn.lock file: https://stackoverflow.com/a/40206145, for versioning issues . In the future, you can run:
yarn install --frozen-lockfile
to get the repo packages exactly the same as other stuff.
There was a problem hiding this comment.
oh hm we include it even when using npm?
| <Center pb={4}> | ||
| <Image src="/LordOfRingLogo.png" alt="Logo" width="300px" /> | ||
| </Center> | ||
| <Center> |
There was a problem hiding this comment.
Looking at the Figma, we want the card to be centered on the page---maybe try putting the image & the card in the same Center component & giving the image absolute positioning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status:
🚧 In development
Description
Fixes hack4impact-uiuc/starter-projects#27
Todos
Screenshots