-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sprikipedia #1275
Sprikipedia #1275
Conversation
@itsimpeccable is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Really thank you for this PR! Make some comments, please don't get me wrong, I'm just being careful with this:)
@@ -26,6 +26,7 @@ export default function MainNavbar(props: MainNavbarProps) { | |||
) : null} | |||
<li><a href='/gallery'>Gallery</a></li> | |||
<li><a href='/get'>Get a Sprig</a></li> | |||
<li><a href='/sprikipedia'>Sprikipedia</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sprikipedia isn't ship'ed yet! So we won't add it to the main navbar for now
@@ -31,4 +31,4 @@ const data = ( | |||
name="CodeMirror" | |||
description=" " /> | |||
</div> | |||
</Categories> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disagree with the rename, getting-started folder follow README.md, and in README.md is https://github.com/hackclub/sprig#acknowledgements
).default; | ||
--- | ||
<Categories name={data["start.categories.name.philosophy"]} title={data["start.categories.title.philosophy"]} > | ||
<p>People learn best when they make things that they care about, which they can then share with others. This type of learning philosophy is called constructionism, and Sprig is a type of microworld. A microworld is an environment where you can discover programming by using it to express yourself.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why delete it? 👀
@@ -14,9 +14,19 @@ const data = ( | |||
<Categories name={data["team.categories.name"]} title={data["team.categories.title"]} > | |||
<p>{data["team.categories.about"]}</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate your changes but I'm already preparing for spriki29 with reference to https://github.com/hackclub/sprig/blob/main/RESPONSIBILITIES.md :)
@@ -0,0 +1,288 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make another PR for your game:)
Hi, is this PR still active? |
I am closing this PR only due to its old age, and thus it seems unlikely it will land. @LucasHT22 feel free, absolutely, to reopen this PR if you desire to push it towards landing to mainline. |
I was not active about sprikipedia and yeah graham, you should've closed
this already.
…On Thu, Jun 13, 2024 at 3:47 PM graham ***@***.***> wrote:
I am closing this PR only due to its old age, and thus it seems unlikely
it will land. @LucasHT22 <https://github.com/LucasHT22> feel free,
absolutely, to reopen this PR if you desire to push it towards landing to
mainline.
—
Reply to this email directly, view it on GitHub
<#1275 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMITSM6EASHZGPOFX7H7REDZHGIFVAVCNFSM6AAAAABADDGXLGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRVGU2TSMRVG4>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
I did moderate changes to the sprikipedia, adding more team members to team page, adding a sprikipedia redirection URL to the homepage, and I made Philosophy and Acknowledgements page to the one page named "About Sprig".