Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

times #1309

Closed
wants to merge 8 commits into from
Closed

times #1309

wants to merge 8 commits into from

Conversation

AbhaySingh502
Copy link

@AbhaySingh502 AbhaySingh502 commented Dec 18, 2023

Your checklist for this pull request

Author name

Author:

About your game

What is your game about?

How do you play your game?

Code

Check off the items that are true.

  • The game was made using the Sprig editor.
  • The game is placed in the in the /games directory.
  • The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
  • The game runs without errors.
  • The name of the file/game contains only alphanumeric characters, -s, or _s.
  • The game name is not the same as the others from gallery

Image (If an image is used)

Thanks for your PR!

Copy link

vercel bot commented Dec 18, 2023

@AbhaySingh502 is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

@grymmy grymmy self-requested a review December 18, 2023 16:13
@grymmy grymmy self-assigned this Dec 18, 2023
@grymmy grymmy added the submission Game submission label Dec 18, 2023
@grymmy
Copy link
Contributor

grymmy commented Dec 18, 2023

Thank you so much for your first PR contribution to Hack Club @AbhaySingh502!!!

Copy link
Contributor

@grymmy grymmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please rename your game's file to limits.js
  2. Please rename your game's screenshot to limits.png
  3. Please update the main description of the PR and fill in:
    • Author name
    • A blurb re: "What is your game about?"
    • A blurb re: "How do you play your game?"
    • Ensure all checkmarks provided are accurate (and checked).

Copy link
Member

@LucasHT22 LucasHT22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complementing @grymmy , this game is a copy of https://sprig.hackclub.com/gallery/Limits, @AbhaySingh502 please make your own game:)

@grymmy
Copy link
Contributor

grymmy commented Dec 19, 2023

Complementing @grymmy , this game is a copy of https://sprig.hackclub.com/gallery/Limits, @AbhaySingh502 please make your own game:)

Thanks @LucasHT22 ! @DevIos01 's CI thang wasn't quite avail yesterday, but now I can see its output which corroborates what you've said:
Screenshot 2023-12-19 at 8 40 26 AM
I believe he's still trying to fix it such that it auto-adds a more pretty comment than this

Copy link

vercel bot commented Dec 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sprig ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2023 8:40pm

@vercel vercel bot temporarily deployed to Preview – sprig December 19, 2023 17:24 Inactive
@vercel vercel bot temporarily deployed to Preview – sprig December 22, 2023 01:40 Inactive
@vercel vercel bot temporarily deployed to Preview – sprig December 22, 2023 03:33 Inactive
@vercel vercel bot temporarily deployed to Preview – sprig December 22, 2023 03:40 Inactive
@vercel vercel bot temporarily deployed to Preview – sprig December 23, 2023 14:34 Inactive
@vercel vercel bot temporarily deployed to Preview – sprig December 23, 2023 20:40 Inactive
Copy link

Plagiarism Report

High plagiarism percentages detected in the following files:

Limits.js: 100%

@grymmy
Copy link
Contributor

grymmy commented Jan 3, 2024

Closing this PR as it seems to be abandoned. If you want to re-open this and advocate for its further consideration, or work on it more in general, please feel free to do so

@grymmy grymmy closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
submission Game submission
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants