Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sprig HAL #2450

Merged
merged 4 commits into from
Oct 11, 2024
Merged

sprig HAL #2450

merged 4 commits into from
Oct 11, 2024

Conversation

recursiveforte
Copy link
Member

@recursiveforte recursiveforte commented Oct 11, 2024 •
edited
Loading

this is mergable but todo: get status of eeprom & whether it's connected

@vercel Vercel
Copy link

vercel bot commented Oct 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sprig ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 4:10pm

@recursiveforte recursiveforte changed the title sprig HAL (todo: detect presence of eeprom) sprig HAL Oct 11, 2024
@recursiveforte recursiveforte marked this pull request as ready for review October 11, 2024 02:15
recursiveforte added a commit that referenced this pull request Oct 11, 2024
@recursiveforte
adapt spade to work w/ HAL (depends on #2450)
5a7dae3
recursiveforte added a commit that referenced this pull request Oct 11, 2024
@recursiveforte
c scaffold (depends on #2450)
63bc2c3
grymmy
grymmy approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@grymmy grymmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add commentary to this PR - looks great tho

@recursiveforte recursiveforte added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit 947ebef Oct 11, 2024
3 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Oct 11, 2024
@recursiveforte
c scaffold (depends on #2450) (#2452)
2b3780f 
* c scaffold (depends on #2450)

* audio comments

* get rid of comment
Cosmin-Mare pushed a commit to Cosmin-Mare/sprig that referenced this pull request Oct 17, 2024
@recursiveforte @Cosmin-Mare
sprig HAL (hackclub#2450)
96b684b 
* sprig HAL (todo: detect presence of eeprom)

* Update HAL.c

* add comments

* commentery
Cosmin-Mare pushed a commit to Cosmin-Mare/sprig that referenced this pull request Oct 17, 2024
@recursiveforte @Cosmin-Mare
c scaffold (depends on hackclub#2450) (hackclub#2452)
0c19df1 
* c scaffold (depends on hackclub#2450)

* audio comments

* get rid of comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grymmy grymmy grymmy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@recursiveforte @grymmy