Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package-lock.json #202

Merged
merged 7 commits into from
Aug 11, 2022
Merged

Conversation

metleeha
Copy link
Contributor

@metleeha metleeha commented Aug 1, 2022

Delete deprecated lib "node-sass" & Add latest "sass"

What this PR does / why we need it

Since lib-sass and node-sass have been deprecated, they fall back to the dart-sass.

Any background context you want to provide?

I installed 1.53.0, the most recent version that can be found in the dart-sass github repo.
Since I could not find any code used by importing the node-sass library, I didn't modify any other code.

What are the relevant tickets?

Fixes #196

Checklist

  • Added relevant tests or not required
  • Didn't break anything

Delete deprecated lib "node-sass" & Add latest "sass"
@CLAassistant
Copy link

CLAassistant commented Aug 1, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@ppeeou ppeeou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@blurfx blurfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@metleeha metleeha force-pushed the update/dependencies branch 2 times, most recently from 22c5b03 to c6659c0 Compare August 6, 2022 05:50
Add fsevents as optionalDependencies for non-mac os
@blurfx
Copy link
Contributor

blurfx commented Aug 6, 2022

Hmm. It might be helpful to use npm ci command instead of npm install on github action workflow.

@blurfx
Copy link
Contributor

blurfx commented Aug 8, 2022

Would you like to delete node_modules and package-lock.json, and run npm install locally, and commit? [ref]

Using npm ci instead npm install
@metleeha
Copy link
Contributor Author

metleeha commented Aug 8, 2022

I deleted the package-lock.json and node-modules file, reinstalled it with the npm i -D fsevents command, and committed it.

@blurfx
Copy link
Contributor

blurfx commented Aug 8, 2022

Great 👍 . Could you resolve the conflict? I think you can just use the new package-lock.json.

@blurfx blurfx mentioned this pull request Aug 8, 2022
2 tasks
@metleeha metleeha force-pushed the update/dependencies branch 2 times, most recently from 8d19005 to 6093b5b Compare August 9, 2022 04:16
@metleeha metleeha force-pushed the update/dependencies branch 3 times, most recently from 2174f63 to 4e31d4d Compare August 9, 2022 13:23
package.json Outdated Show resolved Hide resolved
@metleeha metleeha force-pushed the update/dependencies branch 3 times, most recently from dff0338 to ac82878 Compare August 9, 2022 16:30
npm install -f
@hackerwins hackerwins merged commit 5427c5a into hackerwins:main Aug 11, 2022
hackerwins added a commit that referenced this pull request Aug 12, 2022
@blurfx blurfx mentioned this pull request Aug 28, 2022
2 tasks
mu-hun added a commit to mu-hun/codepair that referenced this pull request Sep 12, 2022
Resolve issue comment: yorkie-team/codepair#204 (comment)

This duplicate key was created in hackerwins#202 PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use sass (dart-sass) instead of node-sass
5 participants