1045 Dynamically name recurring events #1092
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoxShaunR
changed the title
|
Evan will make css changes in a few PR. This is ready for review. |
FoxShaunR
reviewed
Apr 20, 2022
FoxShaunR
reviewed
Apr 20, 2022
FoxShaunR
suggested changes
Apr 20, 2022
FoxShaunR
reviewed
Apr 26, 2022
| @@ -116,7 +116,7 @@ const CreateNewEvent = ({ | |||
| className="create-form-button" | |||
| onClick={() => { | |||
| if (formValues.eventType == null) { | |||
| alert("Please select an event type."); | |||
| setFormErrors("Event type is blank. Select an event type.") | |||
There was a problem hiding this comment.
This should be setting errors to an object with the key being the field name and the value being the error message:
setFormErrors({ eventType: "Event type is blank. Select an event type." })
|
@evanyang1 did you want to finish this or do we want to close this pr? |
|
Closing this because it still needs work and is not super relevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maybe i need to work on the css but from the logic point of view, fixes #1045