Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite #1536

Closed
wants to merge 31 commits into from
Closed

Vite #1536

wants to merge 31 commits into from

Conversation

trillium
Copy link
Member

What changes did you make and why did you make them ?

This PR lets VRMS use node 18+. It touches many files mostly due to the need for Vite to use .jsx extensions

  • Switch to vite build system
  • Update github actions to use modern versions of node
  • Change .js file extension to .jsx for jsx files

Dev environment changes

Vite requires .env variables to have a VITE_ prefix, so in order for this to work properly we'll need to update some of the .env variable names

CLIENT_PORT=
CLIENT_URL=
BACKEND_HOST=
BACKEND_PORT=
REACT_APP_PROXY=
REACT_APP_CUSTOM_REQUEST_HEADER=
VITE_CLIENT_PORT=
VITE_CLIENT_URL=
VITE_BACKEND_HOST=
VITE_BACKEND_PORT=
VITE_REACT_APP_PROXY=
VITE_REACT_APP_CUSTOM_REQUEST_HEADER=

This change also requries devs to install packages again in /client

trillium and others added 30 commits October 30, 2023 13:54
* Add proxy to backend via .env vars
* Configure output dir to be same as create-react-app
* Does not replace old start command yet
The warning is asking for a npm version that isn't yet available in the docker images we use.
Potentially resolves import conflict
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Spiteless-vite development
git pull https://github.com/Spiteless/VRMS.git vite

@trillium trillium closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants