-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ability for PMs to edit Project Information on VRMS #1634
Remove ability for PMs to edit Project Information on VRMS #1634
Conversation
…ally rendering badge in TitleBox based on whether the prop exists
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
client/src/components/ProjectForm.js
Outdated
@@ -223,52 +221,65 @@ export default function ProjectForm({ | |||
</FormControl> | |||
</Grid> | |||
); | |||
console.log( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to stay? Everything else looks good / works as expected
@lcchrty Youre going to have to merge dev in now. |
@bkmorgan3 Just checking in - are we good to merge this PR? |
Thanks @bkmorgan3! 👍 |
Hey @lcchrty , I believe this PR indroduced a bug. TitltedBox is supposed to contain children, not be its own closed element // old
<TitledBox>
{ content }
</TitledBox>
// this PR
<TitledBox />
{ content } |
hey @spiteless - I picked up the issue for the bug I introduced. thanks for catching* this! |
Thanks! As a reminder it's on the team as a whole to make sure that the code merged works as intended, so no harm done :) Thanks for picking up the issue! |
Fixes #1630
What changes did you make and why did you make them?
auth.user.acessLevel === 'admin'
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied