Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTML components to MUI: ./src/components/admin/reports/index.js #1690

Closed
wants to merge 4 commits into from

Conversation

nora-zajzon
Copy link
Member

Fixes #1679

What changes did you make and why did you make them ?

  • Replace all standard HTML components with applicable MUI components.

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b nora-zajzon-nora-zajzon development
git pull https://github.com/nora-zajzon/VRMS.git nora-zajzon

@nora-zajzon nora-zajzon changed the title Update HTML components to MUI: ./src/components/admin/reports/index.js [#1679](https://github.com/hackforla/VRMS/issues/1679) Update HTML components to MUI: ./src/components/admin/reports/index.js Jun 29, 2024
@nora-zajzon nora-zajzon closed this Jul 7, 2024
@nora-zajzon nora-zajzon deleted the nora-zajzon branch July 7, 2024 17:15
@JackHaeg
Copy link
Member

JackHaeg commented Jul 22, 2024

@nora-zajzon Just checking in on this PR, as I can see that it was closed and the branch was deleted. Please let us know if you are planning to create another PR for issue #1679 or if you need any assistance. Thanks for your work on this!

@nora-zajzon
Copy link
Member Author

@JackHaeg I had some issues with my branches and tried rebasing but ended up having to redownload the repository. This caused my pull requests to get a little mixed up. It seems that index.js was never submitted for another pull request but the others were. I can submit a separate PR later, but I think since I already have 3 pending I did not want to add another one to the "in-progress" column.

@JackHaeg
Copy link
Member

JackHaeg commented Jul 22, 2024

@nora-zajzon Thanks for the update! I would recommend submitting a separate PR later for index.js when you have the time. Submitting a PR won't clutter up the "In Progress" column on the project board, since the project board is only for issues, not PRs (which are stored on the separate Pull Review page).

If you are up for submitting a separate PR later on, I'm happy to add a comment on the issue #1679 that you plan to create another, separate PR for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update HTML components to MUI: ./src/components/admin/reports/index.js
2 participants