Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated Checkin Button to Material UI #1725

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

ntrehan
Copy link
Member

@ntrehan ntrehan commented Aug 10, 2024

Fixes #1683

What changes did you make and why did you make them ?

Changed from Default react components to Material UI in CheckinButtons.js

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ntrehan-1683 development
git pull https://github.com/ntrehan/VRMS.git 1683

@JackHaeg JackHaeg requested a review from trillium August 15, 2024 19:02
@JackHaeg
Copy link
Member

JackHaeg commented Aug 15, 2024

@ntrehan & @trillium - looks like the updated MUI buttons used in the above screenshots are no longer viewable to the user (no outline viewable on the button, only button text is viewable which may impact clear usability / understanding that this is an interactive element for the user).

I might recommend using the following MUI component if we want to replicate a similar style to the old button layout: <Button variant="outlined">Outlined</Button>. See more here: https://mui.com/material-ui/react-button/

That said, I'd check with @trillium on this first to get his thoughts :)

Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update HTML components to MUI: ./src/components/presentational/CheckInButtons.js
3 participants