Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify definition of counted parameters #1029

Closed
VGPReys opened this issue Sep 17, 2024 · 1 comment · Fixed by #975
Closed

Simplify definition of counted parameters #1029

VGPReys opened this issue Sep 17, 2024 · 1 comment · Fixed by #975
Assignees
@VGPReys
Labels
enhancement Enhancing an existing feature of adding a new one

Comments

@VGPReys
Copy link
Contributor

VGPReys commented Sep 17, 2024

Desired feature/enhancement

It would be simpler to compute on the fly some of the counted parameters.

Motivation

Simplify the configuration files with unnecessary parameters

Description

The idea is to go from:

[flexref]
nfle = 2    # Useless parameter, as we could compute it from the number of defined flexible segments.
fle_sta_1 = 1
fle_end_1 = 10
fle_seg_1 = "A"
fle_sta_2 = 1
fle_end_2 = 10
fle_seg_2 = "B"

to:

[flexref]
fle_sta_1 = 1
fle_end_1 = 10
fle_seg_1 = "A"
fle_sta_2 = 1
fle_end_2 = 10
fle_seg_2 = "B"
@VGPReys VGPReys added the enhancement Enhancing an existing feature of adding a new one label Sep 17, 2024
@VGPReys VGPReys mentioned this issue Sep 17, 2024
Merged
12 tasks
@sverhoeven
Copy link
Contributor

Nice, this will also simplify the the workflow-builder and haddock3-webapp.

@VGPReys VGPReys self-assigned this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VGPReys VGPReys

Labels
enhancement Enhancing an existing feature of adding a new one
Projects
haddock3 release candidate
Status: Done
Milestone
No milestone
2 participants
@sverhoeven @VGPReys