-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify definition of counted parameters by computing them on the fly from definition. #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if this goes before, after or if it does not matter -> #969 |
Does not matter. |
Related to issue #919 |
VGPReys
added
yaml default parameters
Anything related to the YAML configuration files for default parameters
CNS
Improvements in the CNS engine
labels
Sep 17, 2024
VGPReys
changed the title
Flexseg onthefly nfle
Simplify definition of counted parameters by computing them on the fly from definition.
Sep 17, 2024
AljaLEngel
reviewed
Sep 17, 2024
examples/docking-protein-glycan/docking-flexref-protein-glycan-full.cfg
Outdated
Show resolved
Hide resolved
examples/docking-protein-glycan/docking-flexref-protein-glycan-test.cfg
Outdated
Show resolved
Hide resolved
VGPReys
commented
Sep 17, 2024
Co-authored-by: Anna Engel <[email protected]>
Co-authored-by: Anna Engel <[email protected]>
amjjbonvin
reviewed
Sep 17, 2024
amjjbonvin
approved these changes
Sep 20, 2024
sverhoeven
added a commit
to i-VRESSE/workflow-builder
that referenced
this pull request
Sep 20, 2024
Blocked by haddocking/haddock3#975
Tried it out in the workflow builder, in the preview looks much cleaner when guru catalog is selected, emref is node is added and symmetry fieldset is expanded. |
AljaLEngel
approved these changes
Sep 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CNS
Improvements in the CNS engine
yaml default parameters
Anything related to the YAML configuration files for default parameters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:
tox
tests pass. Runtox
command inside the repository folder-test.cfg
examples execute without errors. Insideexamples/
runpython run_tests.py -b
A solution to compute on the fly counted parameters, such as:
nfle
nncs
(previously known asnumncs
)ncXsym
(previously known asnumcXsym
)nsXsym
(previously known asnumsXsym
)Allows to remove one parameter from user configuration files.
Parameters are (and must still be) present in the
defaults.yaml
as hidden expertise level.Related to #919
Closes #1029