Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement topocg module and helper functions #1007

Closed
wants to merge 25 commits into from
Closed

Conversation

rversin
Copy link
Member

@rversin rversin commented Sep 6, 2024

You are about to submit a new Pull Request. Before continuing, make sure you read the contributing guidelines and that you comply with the following criteria:

  • You have sticked to Python. Please talk to us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there is a (state) purpose
  • Your code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any dependencies, unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

@amjjbonvin amjjbonvin added enhancement Enhancing an existing feature of adding a new one m|topocg topocg module labels Sep 6, 2024
src/haddock/modules/topology/topocg/cns/build-missing.cns Outdated Show resolved Hide resolved
src/haddock/modules/topology/topocg/cns/build-missing.cns Outdated Show resolved Hide resolved
src/haddock/modules/topology/topocg/cns/build-missing.cns Outdated Show resolved Hide resolved
src/haddock/modules/topology/topocg/cns/coval-ace-cys.cns Outdated Show resolved Hide resolved
src/haddock/modules/topology/topocg/cns/covalheme.cns Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To check if we have a CG version of it - or should be adapted

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file is in the same situation as build-missing.cns ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm... since we don't use the AA topo to define breaks, that part is required (also for the protein part)

src/haddock/modules/topology/topocg/defaults.yaml Outdated Show resolved Hide resolved
messages. This parameter controls the verbosity of CNS (verbose, normal or quiet).
group: module
explevel: expert
autohis:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this relevant for CG mode? Do we have various HIS states in Martini and do we check for it?

Copy link
Member Author

@rversin rversin Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have multiple states of HIS in Martini, a protonated (charged) and non protonated (neutral) state. We could implement it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should then be based on the protonation of HIS from the AA model, looking at which hydrogen exist on the HIS ring. Topo and parameters will have to be added for those histidines which have most likely different names.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was just thinking about this !

@amjjbonvin
Copy link
Member

amjjbonvin commented Sep 7, 2024 via email

@rvhonorato rvhonorato marked this pull request as draft September 9, 2024 08:50
@rvhonorato rvhonorato changed the title Topocg implement topocg module and helper functions Sep 9, 2024
Copy link
Member

@rvhonorato rvhonorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds a dependency, please also add the installation instructions and proper checks to ensure it's all configured before the workflow is executed

continue
else:
try:
dssp = DSSP(model, pdbf_path)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind this adds mkdsspas a dependency and it also needs to be installed.

$ python3.9 -m venv dssp-dep
$ source dssp/bin/activate
(dssp-dep) $ pip install biopython==1.79
(dssp-dep) $ wget -q https://files.rcsb.org/view/1CRN.pdb
(dssp-dep) $ python -c 'from Bio.PDB.DSSP import DSSP;DSSP("model", "1CRN.pdb")'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/rodrigo/dbg/.venv/lib/python3.11/site-packages/Bio/PDB/DSSP.py", line 446, in __init__
    dssp_dict, dssp_keys = dssp_dict_from_pdb_file(in_file, dssp)
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/rodrigo/dbg/.venv/lib/python3.11/site-packages/Bio/PDB/DSSP.py", line 233, in dssp_dict_from_pdb_file
    p = subprocess.Popen(
        ^^^^^^^^^^^^^^^^^
  File "/home/rodrigo/.pyenv/versions/3.11.2/lib/python3.11/subprocess.py", line 1024, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/home/rodrigo/.pyenv/versions/3.11.2/lib/python3.11/subprocess.py", line 1901, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'mkdssp'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a first step is to install DSSP: 'sudo apt install dssp'
But I'm still running into some issues

@rvhonorato
Copy link
Member

This is currently at +5,566 lines and I assume you are not close to being done, please break it down into smaller PRs

@amjjbonvin
Copy link
Member

amjjbonvin commented Sep 25, 2024 via email

@amjjbonvin amjjbonvin closed this Sep 25, 2024
@amjjbonvin amjjbonvin deleted the topocg branch September 25, 2024 14:25
@rvhonorato rvhonorato restored the topocg branch September 25, 2024 14:50
@rvhonorato rvhonorato reopened this Sep 25, 2024
@rvhonorato rvhonorato closed this Sep 25, 2024
@rvhonorato rvhonorato deleted the topocg branch September 25, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancing an existing feature of adding a new one m|topocg topocg module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants