Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo at section 6.6 Under the hood #454

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Typo at section 6.6 Under the hood #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5c6873
typo section 6.2
shmuhammadd Mar 23, 2021
1720436
fix typo
shmuhammadd Mar 23, 2021
a768145
fix typo
shmuhammadd Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions action-layout.Rmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ fluidPage(
)
```

Even though you haven't these functions yet, you can guess what's going on by reading their names.
Even though you haven't learned these functions yet, you can guess what's going on by reading their names.
You might imagine that this code will generate a classic app design: a title bar at top, followed by a sidebar (containing a slider) and main panel (containing a plot).
The ability to easily see hierarchy through indentation is one of the reasons it's a good idea to use a consistent style.

Expand Down Expand Up @@ -512,7 +512,7 @@ ui <- fluidPage(
)
```

If you're a HTML/CSS expert, you might be interested to know that can skip `fluidPage()` altogether and supply raw HTML.
If you're a HTML/CSS expert, you might be interested to know that you can skip `fluidPage()` altogether and supply raw HTML.
See "[Build your entire UI with HTML](https://shiny.rstudio.com/articles/html-ui.html)" for more details.

Alternatively, you can use of the HTML helper that Shiny provides.
Expand Down
2 changes: 1 addition & 1 deletion action-workflow.Rmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ server <- function(input, output, session) {

I thought, *it's an eight line app, what could possibly go wrong?* Well, when I opened the app up I saw a **lot** of missing values, no matter what territory I selected.
The code most likely to be the source of the problem was the reactive that selected the data to show: `sales[sales$TERRITORY == input$territory, ]`.
So stopped the app, and quickly verified that subsetting worked the way I thought it did:
So I stopped the app, and quickly verified that subsetting worked the way I thought it did:

```{r}
sales[sales$TERRITORY == "EMEA", ]
Expand Down