[query] Improve error handling and job tracking in ServiceBackend #14751
+323
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grohli
force-pushed
the
batch-job-status
branch
from
32dfbf9 to
7cb9d44
Compare
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
grohli
changed the title
grohli
changed the title
ehigham
requested changes
Nov 5, 2024
hail/src/main/scala/is/hail/backend/service/ServiceBackend.scala
Outdated
Show resolved
Hide resolved
hail/src/main/scala/is/hail/backend/service/ServiceBackend.scala
Outdated
Show resolved
Hide resolved
grohli
force-pushed
the
batch-job-status
branch
from
7cb9d44 to
5e8dd07
Compare
ehigham
reviewed
Nov 5, 2024
ehigham
reviewed
Nov 5, 2024
grohli
force-pushed
the
batch-job-status
branch
from
5e8dd07 to
429847a
Compare
This was referenced Jan 27, 2025
grohli
force-pushed
the
qob-fast-cancel
branch
from
54aae49 to
aa8a2e8
Compare
grohli
force-pushed
the
batch-job-status
branch
from
429847a to
03a6c93
Compare
ehigham
requested changes
Jan 27, 2025
Comment on lines
-315
to
+350
| new CancellationException( | ||
| s"Job group ${jobGroup.job_group_id} for batch ${batchConfig.batchId} was cancelled" | ||
| ) | ||
| } | ||
|
|
||
| r = (Some(error), results) | ||
| } | ||
| def streamSuccessfulJobResults: Stream[(Array[Byte], Int)] = | ||
| for { | ||
| successes <- batchClient.getJobGroupJobs( | ||
| jobGroup.batch_id, | ||
| jobGroup.job_group_id, | ||
| Some(JobStates.Success), | ||
| ) | ||
| job <- successes | ||
| partIdx = job.job_id - startJobId | ||
| } yield (readPartitionResult(root, partIdx), partIdx) | ||
|
|
||
| val r @ (_, results) = | ||
| jobGroup.state match { | ||
| case Success => | ||
| runAllKeepFirstError(executor) { | ||
| (partIdxs, parts.indices).zipped.map { (partIdx, jobIndex) => | ||
| (() => readPartitionResult(root, jobIndex), partIdx) | ||
| } | ||
| } | ||
| case Failure => | ||
| val failedEntries = batchClient.getJobGroupJobs( | ||
| jobGroup.batch_id, | ||
| jobGroup.job_group_id, | ||
| Some(JobStates.Failed), | ||
| ) | ||
| assert( | ||
| failedEntries.nonEmpty, | ||
| s"Job group ${jobGroup.job_group_id} failed, but no failed jobs found.", | ||
| ) | ||
| val error = readPartitionError(root, failedEntries.head.head.job_id - startJobId) | ||
|
|
||
| (Some(error), streamSuccessfulJobResults.toIndexedSeq) | ||
| case Cancelled => | ||
| val error = | ||
| new CancellationException(s"Job Group ${jobGroup.job_group_id} was cancelled.") |
There was a problem hiding this comment.
Revert this - there was more context in the last message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Security Assessment
Delete all except the correct answer:
Impact Description
Mainly just code for testing, nothing security related
(Reviewers: please confirm the security impact before approving)