Add objwrapper pkg #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feiniks
force-pushed
the
wrapper
branch
2 times, most recently
from
9f88fd4
to
1799576
Compare
killing
reviewed
Oct 26, 2024
objwrapper/alioss.py
Outdated
|
|
||
| def read_obj_raw(self, real_obj_id): | ||
| data = self.read_object_content(real_obj_id) | ||
| return data |
There was a problem hiding this comment.
作为一个底层通用的库，只需要提供一个 read_obj(self, key) 的方法就行了。
objwrapper/alioss.py
Outdated
| def get_name(self): | ||
| return 'OSS storage backend' | ||
|
|
||
| def list_objs(self, repo_id=None): |
There was a problem hiding this comment.
作为一个通用的库，不应该有 seafile 特定的信息。这里 repo_id 应该改为 prefix。
objwrapper/s3.py
Outdated
| yield obj | ||
|
|
||
|
|
||
| def obj_exists(self, s3_path): |
objwrapper/s3.py
Outdated
| bucket = self.bucket | ||
| self.client.delete_object(Bucket=bucket, Key=s3_path) | ||
|
|
||
| def stat_raw(self, s3_path): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.