Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

头像服务增强:增加一些国内常用的头像服务商 #145

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wenjing-xin
Copy link

按照已有头像服务的示例,对头像服务源进行增加。

此外我看了下 AvatarProvider 这个类,只有头像服务源名称和服务地址,没有一些参数配置,比如用户想要配置头像源的默认头像以及图片大小还有其他参数,是否可以在 AvatarProvider 这个类中新加一个参数 _params 让用户自己配置一些头像源请求的参数?如有必要,我在重新修改代码,再次提交代码

Copy link

f2c-ci-robot bot commented Jul 29, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jul 29, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang July 29, 2024 02:42
Copy link

f2c-ci-robot bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign johnniang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruibaby
Copy link
Member

ruibaby commented Jul 31, 2024

没有一些参数配置,比如用户想要配置头像源的默认头像以及图片大小还有其他参数,是否可以在 AvatarProvider 这个类中新加一个参数 _params 让用户自己配置一些头像源请求的参数

如果要考虑到支持多个头像源,可能现有的 Gravatar 的配置得改一下,应该将具体的头像源配置用 group(对象)来组织。

image

期望的结构应该是:

{
   provider: "gravatar",
   gravatar: { mirror: "", default: 'monsterid'  },
   cravatar: { ... }
}

@wenjing-xin
Copy link
Author

没有一些参数配置,比如用户想要配置头像源的默认头像以及图片大小还有其他参数,是否可以在 AvatarProvider 这个类中新加一个参数 _params 让用户自己配置一些头像源请求的参数

如果要考虑到支持多个头像源,可能现有的 Gravatar 的配置得改一下,应该将具体的头像源配置用 group(对象)来组织。

image 期望的结构应该是:
{
   provider: "gravatar",
   gravatar: { mirror: "", default: 'monsterid'  },
   cravatar: { ... }
}

我还是没听明白 请问一下 配置文件的这个yaml组织结构到底需要怎么组织?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants