Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shiki code block extension to the editor #1

Merged
merged 5 commits into from
Nov 22, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Aug 1, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

为默认编辑器代码块提供基于 Shiki 的高亮扩展。用于支持在默认编辑器中选择高亮及主题色的功能。

image

此功能需要 PR halo-dev/halo#6428 的支持。

How to test it?

测试安装插件之后,在默认编辑器中的代码块是否可以选择 Shiki 相关的高亮语言。

Does this PR introduce a user-facing change?

为默认编辑器添加基于 Shiki 的代码块扩展。

Copy link

f2c-ci-robot bot commented Aug 1, 2024

@LIlGG: The label(s) kind/feature cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind feature

What this PR does / why we need it:

为默认编辑器代码块提供基于 Shiki 的高亮扩展。用于支持在默认编辑器中选择高亮及主题色的功能。

image

How to test it?

测试安装插件之后,在默认编辑器中的代码块是否可以选择 Shiki 相关的高亮语言。

Does this PR introduce a user-facing change?

为默认编辑器添加基于 Shiki 的代码块扩展。

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 1, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and ruibaby August 1, 2024 09:52
Copy link

f2c-ci-robot bot commented Aug 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign guqing for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruibaby ruibaby changed the title feat: add shiki code block extension to the editor WIP: feat: add shiki code block extension to the editor Aug 2, 2024
@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 2, 2024
@ruibaby ruibaby changed the title WIP: feat: add shiki code block extension to the editor feat: add shiki code block extension to the editor Nov 22, 2024
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2024
@ruibaby
Copy link
Member

ruibaby commented Nov 22, 2024

我将合并此 PR,方便后续按实际反馈和修复问题。

@ruibaby ruibaby merged commit b06c99d into halo-sigs:main Nov 22, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants