Simple partial implementation #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `render` method to Haml::Helpers to provide a simple implementation of partials.
Strictly speaking these aren't unit tests as they touch the filesystem, but that's the nature of partials.
|
This PR isn’t quite ready yet – I’ve just realised I need to make sure the options get passed through to the partial. |
This requires the original options to be available, not just the buffer options, so they are "hidden" inside the scope object.
Instead of original_render, in order to avoid infinite recursion when using more than one alias in a chain.
Don't assume the working directory is the project top level.
Add test assertions assert_css and refute_css, which assert (or refute) that a node matching the specified css string exists in the specified HTML.
Options#to_hash and Engine#render_with_options are needed in more places than just partials. Extract out into there own file.
Use original options passed to render when rendering the layout.
Add some tests for using layouts and partials together.
Remove duplication by extracting code to a class method.
To avoid "multiple values for a block parameter" on 1.8.7.
|
Needs some documentation, otherwise I think it’s pretty much ready. I’ve added a simple layouts implementation. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1