-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added callback option #4
base: master
Are you sure you want to change the base?
Conversation
- in case you want other fallback behavior than going to app store
I wasn't aware that when I make subsequent commits after creating a pull request, Github just adds them to the PR. Anyways, this PR gets a bit convoluted like this |
Great suggestion. Haven't been able to verify, but code looks like it should do the job :) if (settings.callback) {
timeout = setTimeout(settings.callback, settings.delay);
} else if (settings.fallback) {
timeout = setTimeout(openAppStore(Date.now()), settings.delay);
} |
I had it like that before but I figured I didn't want to overrule current behavior. But now that that's an option, how about we let
|
Yep, sounds good! |
The |
Yeah, good idea! |
In our situation we don't want the user to go the app store but we rather provide custom callback behavior that's called when the app is not found
I also added a trailing
;
afterend
in the android url because our Titanium app goes haywire without it.Also, switched
package
andscheme
for same reason