Link to legacy_stdio_definitions only when building with MSVC

[uilianries]

Hello!

We are packaging rebound in Conan and we noted it failed to build using Clang on Linux. The complete failed build log can be found here

The error occurred because the Linux environment was not capable to find the library legacy_stdio_definitions.lib. That library is exclusive for Visual Studio environments:

https://learn.microsoft.com/en-us/cpp/porting/overview-of-potential-upgrade-issues-visual-cpp?view=msvc-170

To provide partial link compatibility with object files (and libraries) compiled with older versions of the Microsoft C Runtime headers, we provide a library, legacy_stdio_definitions.lib, with Visual Studio 2015 and later. This library provides compatibility symbols for most of the functions and data exports that were removed from the Universal CRT. The set of compatibility symbols provided by legacy_stdio_definitions.lib is sufficient to satisfy most dependencies, including all of the dependencies in libraries included in the Windows SDK.

This pull request adds a condition to link that library only when building on Windows and using Visual Studio, avoiding linkage errors in Linux.

/cc @RubenRBS

[hannorein]

Thanks for this! Strange that this didn't come up before. I guess it's not an issue for gcc/icc on Linux?

[uilianries]

Thanks for this! Strange that this didn't come up before. I guess it's not an issue for gcc/icc on Linux?

It didn't fail for me on Linux + GCC. But there is difference depending how you installed your Clang in Linux. In my case, I built it from source, using minimal flags. However, using Clang version distributed via Ubuntu APT there is no such error. Anyway, it should be a feature for Windows only.

Thank for reviewing and accepting it quickly.