Fallback project parameters #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Platform.sh admin console will reroute /project/<project_id> to /<owner>/<project_id> so there is no longer a need to specify the project_url parameter to get a valid link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things going on in this PR:
For the
projectparameter, the project title is now provided in the platform.sh JSON data underpayload > project > title, so we can now make theprojectparameter optional, and an accurate fallback value can be provided.For the
project_urlparameter, it is expected that the URL would be in the formathttps://console.platform.sh/<project_owner_name>/<project_id>. I assume this parameter was exposed because the project_owner_name is not provided in the payload. However, I discovered that the Platform.sh web admin console is smart enough to reroute project URLs to the correct final URL, so thathttps://console.platform.sh/project/<project_id>will automatically redirect tohttps://console.platform.sh/<project_owner_name>/<project_id>. This means that technically, we can now provide a smart and working fallback URL, and therefore theproject_urlparameter is no longer required. I've left the parameter in place for backward compatibility.