feat(HQM-171): Sync NFT with indexer data #1536
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivalaakam
reviewed
Dec 12, 2023
| @@ -21,7 +21,7 @@ export interface NftItemDetailsProps { | |||
| export const NftItemDetails = ({item, onPressSend}: NftItemDetailsProps) => { | |||
| const [imageLayout, onImageLayout] = useLayout(); | |||
| const lastSalePrice = useMemo( | |||
| () => cleanNumber(parseInt(item.last_sale_price, 16) / WEI), | |||
| () => cleanNumber(parseInt(item.price, 16) / WEI), | |||
vivalaakam
reviewed
Dec 12, 2023
| @@ -19,7 +19,7 @@ export const NftViewerItemPreviewLarge = ({ | |||
| const handlePress = useCallback(() => onPress?.(item), [onPress, item]); | |||
| const [layout, onLayout] = useLayout(); | |||
| const lastSalePrice = useMemo( | |||
| () => cleanNumber(parseInt(item.last_sale_price, 16) / WEI), | |||
| () => cleanNumber(parseInt(item.price, 16) / WEI), | |||
devkudasov
force-pushed
the
feat/nft-items
branch
from
6b7204c to
2833a6a
Compare
ragozin-nikita
suggested changes
Dec 22, 2023
| [collection], | ||
| ); | ||
| const item = useMemo(() => getRandomItemFromArray(data), [data]); | ||
| const collection = Nft.getCollectionById(item.id); |
There was a problem hiding this comment.
Component should be observer then
|
|
||
| const lastSalePrice = useMemo( | ||
| () => cleanNumber(parseInt(item.last_sale_price, 16) / WEI), | ||
| () => cleanNumber(parseInt(item.price, 16) / WEI), |
There was a problem hiding this comment.
Should be Balance instance
| @@ -37,7 +35,6 @@ export const NftViewerCollectionPreviewList = ({ | |||
| <FlatList | |||
| data={data} | |||
| numColumns={2} | |||
| keyExtractor={keyExtractor} | |||
There was a problem hiding this comment.
keyExtractor should be implemented
| ); | ||
|
|
||
| return ( | ||
| <SectionList |
There was a problem hiding this comment.
keyExtractor should be implemented
| scrollEnabled={scrollEnabled} | ||
| sections={sections} | ||
| keyExtractor={keyExtractor} |
There was a problem hiding this comment.
Missing keyExtractor
src/contexts/app.ts
Outdated
| @@ -548,6 +549,7 @@ class App extends AsyncEventEmitter { | |||
|
|
|||
| if (changed) { | |||
| Token.fetchTokens(); | |||
There was a problem hiding this comment.
Suggested change
| Token.fetchTokens(); | |
| Promise.all([Token.fetchTokens(), Nft.fetchNft()]); |
| properties: [ | ||
| // https://github.com/quarrant/mobx-persist-store/issues/97 | ||
| // @ts-ignore | ||
| 'nfts', |
There was a problem hiding this comment.
Suggested change
| 'nfts', | |
| 'data', |
| description: item.description, | ||
| created_at: item.created_at, | ||
| price: '100', | ||
| image: item.cached_url ?? 'https://i.ibb.co/9VGgYqf/10.jpg', |
There was a problem hiding this comment.
Suggested change
| image: item.cached_url ?? 'https://i.ibb.co/9VGgYqf/10.jpg', | |
| image: item.cached_url ?? DEFAULT_NFT_IMAGE |
| @@ -66,7 +54,7 @@ export const NftWidgetWrapper = observer(({size}: INftWidget) => { | |||
| case NftWidgetSize.large: | |||
| return ( | |||
| <ShadowCard disablePadding onPress={onPress} style={styles.wrapper}> | |||
| <NftCollectionInfoBanner data={nftCollections} /> | |||
| <NftCollectionInfoBanner data={allNft} /> | |||
There was a problem hiding this comment.
Suggested change
| <NftCollectionInfoBanner data={allNft} /> | |
| <NftCollectionInfoBanner data={Nft.getAll()} /> |
devkudasov
force-pushed
the
feat/nft-items
branch
2 times, most recently
from
4d4515a to
0dd7666
Compare
devkudasov
force-pushed
the
feat/nft-items
branch
from
0dd7666 to
5acfa73
Compare
devkudasov
force-pushed
the
feat/nft-items
branch
from
5acfa73 to
93ffdfb
Compare
|
Close as old and not relevant for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes
Checklist