Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix some function names #3545

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix some function names #3545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/pipeline/converter/jsonnet/jsonnet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ func mapBuild(v *types.Execution, vm *jsonnet.VM) {
fromMap(v.Params, vm)
}

// mapBuild populates repo level variables available to jsonnet templates.
// mapRepo populates repo level variables available to jsonnet templates.
// Since we want to maintain compatibility with drone 2.x, the older format
// needs to be maintained (even if the variables do not exist in gitness).
func mapRepo(v *types.Repository, p *types.Pipeline, vm *jsonnet.VM, publicRepo bool) {
Expand Down
4 changes: 2 additions & 2 deletions app/pipeline/manager/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ func (m *Manager) AfterStep(_ context.Context, step *types.Step) error {
return retErr
}

// BeforeAll signals the build stage is about to start.
// BeforeStage signals the build stage is about to start.
func (m *Manager) BeforeStage(_ context.Context, stage *types.Stage) error {
s := &setup{
Executions: m.Executions,
Expand All @@ -474,7 +474,7 @@ func (m *Manager) BeforeStage(_ context.Context, stage *types.Stage) error {
return s.do(noContext, stage)
}

// AfterAll signals the build stage is complete.
// AfterStage signals the build stage is complete.
func (m *Manager) AfterStage(_ context.Context, stage *types.Stage) error {
t := &teardown{
Executions: m.Executions,
Expand Down