Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hearbeat register #45
base: main
Are you sure you want to change the base?
Add hearbeat register #45
Changes from 3 commits
4145efa
9764e38
11d4854
df82664
a188592
940d83c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we fix this address now? Or do we need to wait for merging #39 and #38 beforehand?
In general I guess this is an interesting question regarding numbering of newly proposed common registers, should the address be part of the proposal, or should we number them incrementally as they get merged on a first-come, first-served basis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think there is any requirement for registers to be sequential right now. Or at least in the protocol. I think that in general we should honor the "reserved" register of the PR in case people implemented a proof-of-concept already. But maybe there is a stronger reason to follow the sequence?