Allow user to mark all topics as read #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests were passing erroneously as a result. Instead, use explicit signin and signouts in order in the test.
Turbo caching page meant that users often saw outdated read vs unread thread styling on the main page (since we're not controlling this in Javascript). For now, I'm disabling the caching, which will slow down load times for users. In the longterm, I'd like to move toward updating state before page cache using Turbo hooks.
hartsick
force-pushed
the
mark-all-read
branch
2 times, most recently
from
95e5041
to
76d8004
Compare
Use asset pipeline and tailwind gem for CSS compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #62
Also changes default of #67 , to be closed (doesn't handle state)