Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More refactoring #9

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

jkraemer
Copy link

Few refactorings in controllers / models. Likely I'll be adding more here soon.

  • There is no point in using unloadable in Redmine plugins nowadays.
  • require_dependency should only be used when necessary
  • made few parts of the code more Ruby-like and thus more readable (imho)

… is always

there since we're requiring Redmine 3.4
- it was always running without repository
- also projects_trackers fixture was missing (which only mattered when running
  the test in isolation)
@coveralls
Copy link

coveralls commented Mar 12, 2018

Coverage Status

Coverage decreased (-0.1%) to 87.619% when pulling fecd3d0 on planio-gmbh:more-refactoring into 61f3a34 on haru:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 87.619% when pulling fecd3d0 on planio-gmbh:more-refactoring into 61f3a34 on haru:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 87.619% when pulling fecd3d0 on planio-gmbh:more-refactoring into 61f3a34 on haru:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 87.619% when pulling fecd3d0 on planio-gmbh:more-refactoring into 61f3a34 on haru:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants