Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix map numbers #102

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Fix map numbers #102

merged 2 commits into from
Apr 4, 2024

Conversation

tinykite
Copy link
Contributor

@tinykite tinykite commented Apr 4, 2024 •
edited
Loading

What this does

  • Flip-flops the overall stats for the map, which were displaying the wrong numbers for national vs state totals
  • Adds a small formatting function to properly add commas to all of the numbers being displayed in the map

Closes ENG-769

Screenshot

The new map should now properly display both the right numbers and formatted in the right way for US numbers:
Screenshot of fixed map

@tinykite tinykite marked this pull request as ready for review April 4, 2024 15:26
@tinykite tinykite requested a review from a team as a code owner April 4, 2024 15:26
@tinykite tinykite requested review from teovin and removed request for a team April 4, 2024 15:26
@rebeccacremona rebeccacremona removed the request for review from teovin April 4, 2024 16:32
@tinykite
Copy link
Contributor Author

tinykite commented Apr 4, 2024

Thanks Becky!

@tinykite tinykite merged commit 1e2f821 into harvard-lil:main Apr 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebeccacremona rebeccacremona rebeccacremona approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tinykite @rebeccacremona