Dialog fix #104
Merged
Dialog fix #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinykite
commented
Jul 3, 2024
Comment on lines
-251
to
-256
| <a | ||
| class="nav__link" | ||
| @click="${this._openSearchInterstitial}" | ||
| href="https://www.courtlistener.com/opinion/" | ||
| >Search</a | ||
| > |
There was a problem hiding this comment.
I think this link element was likely another remnant of a past development effort — potentially before the dialog existed. I swapped it out for a button, which typically toggles a dialog.
tinykite
commented
Jul 3, 2024
| } | ||
|
|
||
| render() { | ||
| return html` | ||
| <div> |
There was a problem hiding this comment.
This was probably a remnant from past development efforts. It's not functionally needed, so I removed it.
rebeccacremona
approved these changes
Jul 3, 2024
teovin
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
This primary makes an accessibility fix to a dialog that is triggered by clicking the "Search" option in the main navigation for the CAP static project, with some small additional improvements.
Screenshots
The dialog now includes a "close" button to dismiss it and return to the previously focused element. The button's close icon itself is 24x24 but the total target size for the button is substantially larger — to meet guidelines outlined by WCAG 2.5.5 AAA for the minimum target size for pointer inputs.
Additionally, the dialog no longer hides content that overflows its container. Instead, a browser will now natively provide a scroll to surface additional content:
