Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update validators.py #261

Merged
merged 3 commits into from
Feb 21, 2020
Merged

Update validators.py #261

merged 3 commits into from
Feb 21, 2020

Conversation

qurbat
Copy link
Contributor

@qurbat qurbat commented Feb 10, 2020

@qurbat qurbat requested a review from jace February 10, 2020 03:51
@qurbat qurbat marked this pull request as ready for review February 19, 2020 08:05
jace
jace requested changes Feb 19, 2020
View reviewed changes
Copy link
Member

@jace jace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small things needing attention. Mostly okay otherwise.

baseframe/forms/validators.py Outdated Show resolved Hide resolved
baseframe/forms/validators.py Outdated Show resolved Hide resolved
baseframe/forms/validators.py Outdated Show resolved Hide resolved
baseframe/forms/validators.py Outdated Show resolved Hide resolved
@qurbat qurbat merged commit e4f9c9b into master Feb 21, 2020
@qurbat qurbat deleted the validators-patch branch February 21, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jace jace jace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qurbat @jace