Transferrable until #106
Closed
Transferrable until #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ffice into transferrable_until
…or variables. CC previous assignee incase of ticket transfer.
| @@ -38,11 +39,16 @@ def assign(order): | |||
| db.session.commit() | |||
| else: | |||
| if line_item.current_assignee: | |||
| past_assignee = line_item.current_assignee.email | |||
There was a problem hiding this comment.
I suggest previous_assignee_email instead of past_assignee.
| @@ -55,15 +55,19 @@ def send_line_item_cancellation_mail(line_item_id, subject="Ticket Cancellation" | |||
|
|
|||
|
|
|||
| @job('boxoffice') | |||
| def send_ticket_assignment_mail(line_item_id): | |||
| def send_ticket_assignment_mail(line_item_id, past_assignee): | |||
There was a problem hiding this comment.
This method can be little more lightweight. It can just accept a list of recipients from the caller, instead of having knowledge of a 'past assignee'.
| """ | ||
| Sends a confirmation email once details are filled and ticket has been assigned. | ||
| """ | ||
| with app.test_request_context(): | ||
| line_item = LineItem.query.get(line_item_id) | ||
| order = line_item.order | ||
| subject = order.item_collection.title + ": Here's your ticket" | ||
| msg = Message(subject=subject, recipients=[line_item.current_assignee.email], bcc=[order.buyer_email]) | ||
| if past_assignee: | ||
| recipient_list = [order.buyer_email, past_assignee] |
There was a problem hiding this comment.
This should be cc_list since recipient would imply the intended recipient of the email.
| @@ -55,15 +55,15 @@ def send_line_item_cancellation_mail(line_item_id, subject="Ticket Cancellation" | |||
|
|
|||
|
|
|||
| @job('boxoffice') | |||
| def send_ticket_assignment_mail(line_item_id): | |||
| def send_ticket_assignment_mail(line_item_id, recipient_list, cc_list): | |||
There was a problem hiding this comment.
I think cc_list should have [] as its default parameter since it isn't mandatory.
Admin page to download reports.
added uglify to gulp pipeline
A better CSV report for tickets
…d-fieldstoform
Allow checkbox field in the attendee form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open a new PR #118 based out of the latest master