Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discount policy form and ticket assignment page #515

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

vidya-ram
Copy link
Member

  1. Fix Discount Type input values in the new/edit discount policy form
  2. Fix display of ticket description in the ticket assignment form

@vidya-ram vidya-ram requested a review from jace June 27, 2024 12:06
Copy link
Member

@jace jace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be an enum object that's kept in sync with backend, or it should be string-based. Can you check for other enums hardcoded like this? We're now using 1-indexed enums in the backend.

@vidya-ram vidya-ram merged commit 2388e73 into main Jun 27, 2024
30 checks passed
@vidya-ram vidya-ram deleted the fix-discount-form branch June 27, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants