Support messaging over WhatsApp (foundation only) #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jace
requested changes
Jan 31, 2023
for more information, see https://pre-commit.ci
jace
changed the title
jace
requested changes
Nov 17, 2023
| # Register the fact that we got a WhatsApp event. | ||
| # If there are too many rejects, then most likely a hack attempt. | ||
|
|
||
| # FIXME: Where is the call verification? |
There was a problem hiding this comment.
The verification happens only once during registration of the webhook in the Meta Business Suite
There was a problem hiding this comment.
This still needs call verification. Anybody can call this endpoint.
Comment on lines
+44
to
+45
| # FIXME: Handle multiple events in a single call, as it clearly implied by `changes` | ||
| # and `statuses` being a list in this call |
Comment on lines
+276
to
+279
| # Send whatsapp message | ||
| def send_whatsapp( | ||
| self, flash_success: bool = True, flash_failure: bool = True | ||
| ) -> whatsapp.WhatsappTemplate | None: |
There was a problem hiding this comment.
This needs a wrapping send_phone method that picks SMS or WhatsApp automatically — or both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.