Recover from deadlock in session_truncate fixture #1885
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updated fixture does not have a test, so we must assume it works until a deadlock error happens again. My first attempt at writing a test did not go well because (a) we're testing for an error in a fixture, which requires pytest's pytester plugin (disabled by default) and a special operating condition for it, and (b) to simulate a PostgreSQL deadlock we need parallel database connections (thread, process or async with wait) that are also contained within a single test and teardown cleanly. This is a larger task than I had expected, so I'll leave it for another PR.