Allow older timezone names in auto-detection #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python's zoneinfo depends on tzdata in some instances. We still use pytz for timezones, so this is for future transition. Two other updates are security releases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaScript timezone detection reports the old name
Asia/Calcuttainstead of the currentAsia/Kolkata. These are known renames in the timezone database, so Funnel now builds a remap table from thetzdata.zitext file included with thetzdatapackage. System zoneinfo does not always include this file or has a truncated version — macOS Sonoma doesn't have it, and Ubuntu 20.04's file has 150 aliases for the 2023c database, while tzdata's copy for the same 2023c release has 246 entries.