Imgee V2 #59

iambibhas · 2017-04-18T08:13:17Z

Removes celery from the system
Removes unnecessary code and a lot of cleanup
Replaced previous tests. Previously the tests were making requests to the HTTP endpoints. But some of those endpoints are authenticated. And no way to test those endpoints right now. Not sure how they used to work before. So now we moved most of the view logic to separate functions and testing those.
Added support for new file types - PSD, AI, SVG, PDF, XCF, WEBP and CDR.

Removed celery as dependency

New tests

some more cleanups

shreyas-satish · 2017-04-18T08:14:59Z

imgee/models/stored_file.py

+        if new_labels != old_labels:
+            self.labels = labels
+
+        if (new_labels == old_labels):


Brackets aren't really necessary here.

Removed them.

shreyas-satish · 2017-04-18T08:21:51Z

tests/test_upload.py

+        return sf
+
+    def test_save_file(self):
+        resp = requests.get("http:" + os.path.join(app.config.get('MEDIA_DOMAIN'), app.config.get('AWS_FOLDER'), "{}{}".format(self.sf.name, self.sf.extn)))


Is there a method that gives you the path for a filename?

Yeah, fixed this.

shreyas-satish · 2017-04-18T09:28:25Z

imgee/views/files.py

+from sqlalchemy import and_
+
+from coaster.views import load_model, load_models
+from imgee import app, forms, lastuser


Maybe import just the relevant classes and functions from forms, instead of importing everything?

We typically use forms for from baseframe import forms, so it may be confusing to someone reading this file and wondering what the forms namespace is.

jace

Initial comments. Going through the rest.

jace · 2017-04-24T09:15:32Z

.gitignore

+*.bak
+instance/production.env.sh
+imgee/static/gen
+tests/imgee/


What goes in this folder?

Uploads made during running the tests.

-> % tree tests/imgee tests/imgee └── static └── test_uploads ├── 0a795f311f90494292df03f64317c57d.svg ├── 1ce47cefeec241b9a7266ed852131e48.svg ├── 28029c34ba9947ad8e6ce53e074b3617.gif ├── 318c1dbbefa7451e82fee1d7c77e3282.svg ├── 31b9a8a9be6947db9913fdb38c0fd4e2.jpeg

jace · 2017-04-24T09:16:59Z

.travis.yml

  - nosetests --with-coverage
-install: 
+install:
  - sudo apt-get -qq install zlib1g-dev libfreetype6-dev liblcms1-dev libwebp-dev libjpeg-dev libpng-dev libfreetype6-dev libtiff4-dev librsvg2-dev ghostscript imagemagick pandoc
  - pip install -r requirements.txt
  - pip install nose coverage BeautifulSoup4 Pillow


Are BS and Pillow only required for tests?

Actually, no. Neither of them are being used now. Removing.

jace · 2017-04-24T09:18:45Z

alembic/versions/347ba3ac054f_update_image_attrs.py

+    connection = op.get_bind()
+    Session = sessionmaker(bind=connection.engine)
+    session = Session(bind=connection)
+    imgs = session.query(StoredFile).filter_by(size=None).options(load_only("id", "name", "title"))


i believe Alembic gives you a session already. Is a new session necessary?

@jace can do that with op.execute() but then have to define the schema for stored file in this migration file itself. I wanted to avoid it. so creating a session and using that so that I can use the ORM.

That's a problem. Migrations must never import models. They must always be locally defined in the migration.

The reason is that the model may no longer exist in the same form in the code when the migration is run. You need version controlling.

@jace that's exactly why I did this. The way it was before, the model was imported and used which was breaking the migrations. The way above, it uses the session of the migration, so it uses the version of the model at that point in migration and not the current version of the model.

That doesn't make sense. You're importing from models. You always get the current version of the model.

jace · 2017-04-24T09:25:22Z

imgee/__init__.py

-from .async import TaskRegistry
+from .tasks import TaskRegistry
+
+registry = TaskRegistry(os.getenv('ENV', 'production'))


Any dependency on system environment should be in coaster.app. The system environment is not a secure place for keeping settings.

Can I set this inside the init_for(env) function and then use env? TaskRegistry has name='default' set by default. I wanted to use something more verbose for the redis keys. hence did this.

Hardcode name='imgee'?

jace · 2017-04-24T09:35:42Z

imgee/models/stored_file.py

+    def dict_data(self):
+        return dict(
+            title=self.title,
+            uploaded=self.created_at.strftime('%B %d, %Y'),


Use .isoformat() + 'Z'

jace · 2017-04-24T10:01:18Z

imgee/storage.py

            img_name = scaled.name
        else:
            size = get_fitting_size((img.width, img.height), size_t)
            resized_filename = get_resized_filename(img, size)
-            job = queueit('resize_and_save', img, size, is_thumbnail=is_thumbnail, taskid=resized_filename)
-            return job
+            registry = imgee.registry


This line is a repeat of the one above.

jace · 2017-04-24T10:36:40Z

imgee/storage.py

+from imgee.utils import (
+    newid, guess_extension, get_file_type,
+    path_for, get_s3_folder, get_s3_bucket,
+    download_frm_s3, get_width_height, ALLOWED_MIMETYPES,


Shouldn't this be named download_from_s3?

Yeah. Fixing.

jace · 2017-04-24T10:43:14Z

imgee/storage.py

+                img_name = resize_and_save(img, size, is_thumbnail=is_thumbnail)
+            except Exception as e:
+                # something broke while processing the file
+                raise e


This except block is redundant. You only need the finally block.

jace · 2017-04-24T11:10:00Z

imgee/storage.py

@@ -101,13 +120,13 @@ def save_on_s3(filename, remotename='', content_type='', bucket='', folder=''):
        k = b.new_key(folder+filename)
        headers = {
            'Cache-Control': 'max-age=31536000',  # 60*60*24*365
-            'Content-Type': get_file_type(fp),
+            'Content-Type': get_file_type(fp, filename),
+            'Expires': datetime.now() + timedelta(days=365)


Use utcnow(). Also, don't you need to convert to string?

jace · 2017-04-25T06:59:01Z

imgee/storage.py

@@ -150,7 +171,11 @@ def get_fitting_size((orig_w, orig_h), size):
    >>> get_fitting_size((200, 500), (400, 600))
    [240, 600]
    """
-    if size[0] == 0 and size[1] == 0:
+    if orig_w == 0 or orig_h == 0:
+        # this is either a cdr file or a zero width file


What's a "zero width" file? Technically that can't be an image. Helps to clarify which of the following is the case:

We are unable to parse this image to extract its size.

It's a vector image with no size in pixels. However, it will still have an aspect ratio that matters when resizing.

1 is the practical case. We're unable to parse the image's width and height.

jace

More comments.

jace · 2017-04-25T07:07:29Z

imgee/storage.py

-
-@celery.task(name='imgee.storage.delete', base=BaseTask)
-def delete(stored_file):
+def delete(stored_file, commit=True):
    """
    Delete all the thumbnails and images associated with a file, from local cache and S3.
    Wait for the upload/resize to complete if queued for the same image.


Where's the waiting happening?

The waiting was there with celery where this function will just wait if a resize operation is going on. Right now there is no wait. The delete function will delete everything even if something is going on parallel. What should be the ideal flow of this? Let's saw a resize task is going on. There is an entry for the file in taskregistry. what should the delete function do?

jace · 2017-04-25T07:08:28Z

imgee/storage.py

-    db.session.commit()
+
+    if commit:
+        db.session.commit()


What happens if there was a background thumbnail task? Will it continue running and finish generating a thumbnail?

Question above. I can add few(2-3 maybe) seconds of waiting to delete function to wait for any resize task to be finished. But what if the resize isn't done by that time? What should the delete function do?

Let's file this as a separate ticket and move on. If a user uploads an image and immediately deletes it, while a thumbnail render is still in progress, does it clean up properly?

jace · 2017-04-25T07:10:20Z

imgee/tasks.py

+        self.connection = redis.from_url(connection)
+
+    def add(self, taskid):
+        self.connection.sadd(self.key, taskid)


This is not a timed key (Redis only supports TTL on top-level keys), so there is the possibility of a task (a) getting stuck and running longer than a timeout period, or (b) crashing and not cleaning up, so it appears to still be running. Where's the cleanup process?

Can we add a timestamp along with this key and then clear that ourselves inside the get_resized_image() function?

jace · 2017-04-25T07:19:23Z

imgee/utils.py

 from subprocess import check_output, CalledProcessError
+from urlparse import urljoin
+from uuid import uuid4


Use uuid1mc from coaster.utils wherever possible. uuid4 has bad database indexing performance because of the randomness.

jace · 2017-04-29T08:33:11Z

alembic/versions/347ba3ac054f_update_image_attrs.py

+    connection = op.get_bind()
+    Session = sessionmaker(bind=connection.engine)
+    session = Session(bind=connection)
+    imgs = session.query(StoredFile).filter_by(size=None).options(load_only("id", "name", "title"))


That's a problem. Migrations must never import models. They must always be locally defined in the migration.

jace · 2017-04-29T08:34:10Z

alembic/versions/347ba3ac054f_update_image_attrs.py

+    connection = op.get_bind()
+    Session = sessionmaker(bind=connection.engine)
+    session = Session(bind=connection)
+    imgs = session.query(StoredFile).filter_by(size=None).options(load_only("id", "name", "title"))


The reason is that the model may no longer exist in the same form in the code when the migration is run. You need version controlling.

) * function name fix, using uuid1mc, time format fix * deleting keys from registry when deleting a file * restructured TaskRegistry to use Redis Keys with TTL set to 60 seconds instead of assigning them to a set * re-adding nose and coverage to travis file, removed it by mistake * using runtests.py file to run tests in travis * reordered functions and better string formating * made the redis key expiry time an argument * assigning error handler the right way * not resizing if the gif image is animated * added pillow as dependency * using redis pipeline to delete multiple keys * missed one place to use redis pipeline * deleted runtests.py, not needed anymore * fixed typo * fixed some import issues * moved upload directory creation to manage.py * added some comments * moved importing app inside the only function that uses it * Update runtests.sh * added manage.py init to runtests * removed mkdir from travis config * fixed upload path issue * moar fixes to registry, cleanup, moved back to uuid4 * fixed typo * setting test environment variable in travis file * setting env in existing block, otherwise it gets overwritten * moved the init command out of if block * rearranged travis config, cleanup of upload directory path

jace

First set of comments. Have to finish review for the rest.

jace · 2017-05-02T10:45:32Z

alembic/versions/347ba3ac054f_update_image_attrs.py

+    connection = op.get_bind()
+    Session = sessionmaker(bind=connection.engine)
+    session = Session(bind=connection)
+    imgs = session.query(StoredFile).filter_by(size=None).options(load_only("id", "name", "title"))


That doesn't make sense. You're importing from models. You always get the current version of the model.

jace · 2017-05-02T10:46:35Z

imgee/__init__.py

-from .async import TaskRegistry
+from .tasks import TaskRegistry
+
+registry = TaskRegistry(os.getenv('ENV', 'production'))


Hardcode name='imgee'?

jace · 2017-05-02T10:47:22Z

imgee/__init__.py

@@ -40,14 +37,12 @@ def error403(error):
 def init_for(env):
    coaster.app.init_app(app, env)
    baseframe.init_app(app, requires=['baseframe', 'picturefill', 'imgee'])
-    app.error_handlers[403] =  error403
+    app.error_handlers[403] = error403


Is this Flask's recommended way of defining an error handler? If not, we should use the recommended way.

jace · 2017-05-02T10:49:31Z

imgee/__init__.py

@@ -40,14 +37,12 @@ def error403(error):
 def init_for(env):
    coaster.app.init_app(app, env)
    baseframe.init_app(app, requires=['baseframe', 'picturefill', 'imgee'])
-    app.error_handlers[403] =  error403
+    app.error_handlers[403] = error403
    lastuser.init_app(app)
    lastuser.init_usermanager(UserManager(db, models.User))
    if app.config.get('MEDIA_DOMAIN') and (
            app.config['MEDIA_DOMAIN'].startswith('http:') or
            app.config['MEDIA_DOMAIN'].startswith('https:')):


According to the docs, startswith takes a tuple. You can use: app.config['MEDIA_DOMAIN'].startswith(('http:', 'https:'))

jace · 2017-06-27T02:50:48Z

imgee/__init__.py

-celery.conf.add_defaults(app.config)
-registry.set_connection()
-app.register_blueprint(api, url_prefix='/api/1')
+app.upload_folder = os.path.join(app.static_folder, app.config.get('UPLOADED_FILES_DIR'))


Use werkzeug's secure_filename here.

jace · 2017-06-27T04:31:09Z

imgee/views/files.py

+    if form.validate_on_submit():
+        file_name = request.form.get('file_name')
+        q = and_(Profile.userid.in_(g.user.user_organizations_owned_ids()), StoredFile.name == file_name)
+        f = StoredFile.query.filter(q).first_or_404()


This query is broken. It does not check for any association between StoredFile and Profile. Any user's file can be edited. Security breach.

The query you want:

if profile.userid not in g.user.user_organizations_owned_ids(): abort(403) f = StoredFile.query.filter_by(profile=profile, name=file_name).first_or_404()

if the edit permission is granted correctly in the Profile model, the abort check may be unnecessary. Confirm that.

@jace how do I confirm the permissions granted?

Examine g.permissions in the debugger. Look up the permissions methods on the Profile and StoredFile models to see if either of them grants edit and if so, under what conditions.

@jace does this look right?

ipdb> g.permissions set(['edit', 'new-file', 'new-label', u'siteadmin', 'new', 'view', 'delete']) ipdb> profile.permissions(g.user) set(['edit', 'new-file', 'new-label', 'new', 'view', 'delete'])

How to check under what condition part?

jace · 2017-06-27T04:36:31Z

imgee/views/files.py

+@lastuser.requires_login
+@load_models(
+    (Profile, {'name': 'profile'}, 'profile'),
+    (StoredFile, {'name': 'file'}, 'stored_file'),


Security breach unless you use (StoredFile, {'name': 'file', 'profile': 'profile'}, 'stored_file'),

jace · 2017-06-27T04:40:11Z

imgee/views/files.py

+    permission=['edit', 'siteadmin'])
+def update_title_json(profile, stored_file):
+    form = UpdateTitle()
+    if form.validate_on_submit():


Security breach unless you use:

if profile.userid not in g.user.user_organizations_owned_ids(): abort(403) if form.validate_on_submit():

This is also subject to how the edit permission is granted.

jace · 2017-06-27T04:43:07Z

imgee/views/files.py

+    permission=['delete', 'siteadmin'])
+def delete_file(profile, img):
+    form = DeleteImageForm()
+    if form.is_submitted():


Use form.validate_on_submit() to protect against CSRF.

jace · 2017-06-27T04:43:33Z

imgee/views/files.py

+@load_models(
+    (Profile, {'name': 'profile'}, 'profile'),
+    (StoredFile, {'name': 'image', 'profile': 'profile'}, 'img'),
+    permission=['delete', 'siteadmin'])


Confirm the delete permission is granted correctly.

jace

Review part two of two.

jace · 2017-06-27T06:14:29Z

imgee/views/index.py

 @load_model(Profile, {'name': 'profile'}, 'profile',
-    permission=['view', 'siteadmin'], addlperms=lastuser.permissions)
+    permission=['view', 'siteadmin'])


You need the addlperms parameter to receive siteadmin. It's needed anywhere you're checking for the siteadmin permission.

jace · 2017-06-27T06:15:50Z

imgee/views/index.py

 def pop_up_gallery(profile):
    label = request.args.get('label')
    files = profile.stored_files
    if label:
-        files = files.join(StoredFile.labels).filter(Label.name==label)
+        files = files.join(StoredFile.labels).filter(Label.name == label)
    files = files.order_by('stored_file.created_at desc').all()


Change to files.order_by(db.desc(StoredFile.created_at))

jace · 2017-06-27T06:17:45Z

imgee/views/index.py

    title_form = forms.EditTitleForm()
    return render_template('profile.html', profile=profile, files=files, title_form=title_form, unlabelled=True)

+
 def get_prev_next_images(profile, img, limit=2):
    # query for "all" images though we need just the `limit`
    # bcoz we don't know how many are there in deleteQ.
    imgs = profile.stored_files.order_by('created_at desc').all()


This query is terribly inefficient. You should ask the database to tell you what's previous and next, and return only those.

prev = profile.stored_files.filter(StoredFile.created_at <= img.created_at, StoredFile.id != img.id).order_by('created_at desc').limit(limit).all() next = profile.stored_files.filter(StoredFile.created_at >= img.created_at, StoredFile.id != img.id).order_by('created_at').limit(limit).all()

jace · 2017-06-27T06:26:27Z

imgee/views/labels.py

+    if saved:
+        db.session.commit()
+        status = {'+': ('Added', 'to'), '-': ('Removed', 'from'), '': ('Saved', 'to')}
+        plural = 's' if len(saved) > 1 else ''


Use ngettext for plural text. Don't do this.

Use separate strings for each action so they can be localized properly. Guide to ngettext at https://pythonhosted.org/Flask-BabelEx/#using-translations

jace · 2017-06-27T06:28:39Z

imgee/views/labels.py

@@ -104,26 +115,7 @@ def utils_save_label(label_name, profile, commit=True):


 def utils_delete_label(label):
+    if isinstance(label, str):


basestring, not str

jace · 2017-06-27T06:31:19Z

runtests.sh

+#!/bin/sh
+set -e
+export FLASK_ENV="TESTING"
+export PYTHONPATH=$(dirname $0)  # setting project root as PYTHONPATH


Is this necessary anymore?

…try(redis)

jace · 2017-07-12T07:03:51Z

imgee/models/stored_file.py

+        return dict(
+            title=self.title,
+            uploaded=self.created_at.isoformat() + 'Z',
+            filesize=app.jinja_env.filters['filesizeformat'](self.size),


Why not just call this function directly? Unless it's an inbuilt Jinja filter?

It's an inbuilt filter of jinja.

Looks like it needs a binary parameter too. https://github.com/pallets/jinja/blob/master/jinja2/filters.py#L459

Do we want the binary format? By default it's False.

jace · 2017-07-12T07:05:31Z

imgee/storage.py

+
+            if resized_filename in registry:
+                # file is still being processed
+                # returning None will show "no preview available" thumbnail


We should distinguish between "no preview available" and "loading". Latter should show a spinner.

We only have one scenario right now, what to show when an image is processing. so maybe instead of "no preview available" let's just show "loading" spinner. The no preview case might be possible if a file fails to process. but that needs some better handling I think. can I file that as a separate ticket and make this no-preview thumbnail to loading spinner?

jace · 2017-07-12T07:06:56Z

imgee/storage.py

-    tn = Thumbnail(name=name, width=tn_w, height=tn_h, stored_file=img)
-    db.session.add(tn)
-    db.session.commit()
+    if Thumbnail.query.filter(Thumbnail.name == name).isempty():


What are these name fields here? On the Thumbnail model and in the tn_name parameter? Please add comments to clarify. This may also need a separate ticket to determine if we're doing this correctly. For example, it should be possible to make both JPEG and WebP thumbnails of the same image.

Thumbnail model only saves the name part of the thumbnail, without extension. So right now it's not possible to have multiple thumbnails of different types. can be implemented. separate ticket?

Yes, separate ticket.

A sample of what's in name as a comment in the code will help.

Added some comments.

jace · 2017-07-12T07:13:25Z

imgee/utils.py

-        o = check_output('identify -quiet -ping -format "%wx%h" {}'.format(img_path), shell=True)
-        return tuple(int(dim) for dim in o.split('x'))
+        if extn in ['.pdf', '.gif']:
+            o = check_output('identify -quiet -ping -format "%wx%h" {}[0]'.format(img_path), shell=True)


Can we move all these commands into a single place? Having them littered around code like this makes it hard to find. This can be a separate ticket.

these commands are just to figure out the resolutions of images, and they are only inside this function. can move them somewhere else and pick one depending on file types but filetypes like cdr requires 2 commands to figure out the size, so not sure. Can turn this function to a ResolutionDetector class. That'll be more organized i think, but not sure if that'll be better.

File a ticket and return to this later.

jace · 2017-07-12T07:19:00Z

website.py

@@ -1,4 +1,4 @@
 import sys
-import os.path
+import os


If you're using nothing else from the os module, import os.path. It's the recommended approach.

Done in all the places we're using just os.path.

* removed celery as dependency * fixed - was missing folder name when downloading file * handling multiple resize request for same file * removed print statements * if there is an error while processing a file, raise it * fixed comment * removed all tests * removed more unnecessary things * removed unnecessary imports and minor cleanup * renamed async.py * added label tests * separating label logic * fixed label tests * more cleanup, moved some views out of index.py * cleaned up label saving codes a little * added tests for upload and delete * updated status code for delete test * mixed couple of migrations and showing error * some more cleanups * using get_image_url to create image url * not showing delete label button if not logged in * importing only the needed forms * added tests for resizing files and testing with multiple file types * comparing redirect location with generated thumbnail url * added redis to travis * fixed fixtures file to use new init_app behavior * Function name fix, using uuid1mc, time format fix, TaskRegistry fix (#60) * function name fix, using uuid1mc, time format fix * deleting keys from registry when deleting a file * restructured TaskRegistry to use Redis Keys with TTL set to 60 seconds instead of assigning them to a set * re-adding nose and coverage to travis file, removed it by mistake * using runtests.py file to run tests in travis * reordered functions and better string formating * made the redis key expiry time an argument * assigning error handler the right way * not resizing if the gif image is animated * added pillow as dependency * using redis pipeline to delete multiple keys * missed one place to use redis pipeline * deleted runtests.py, not needed anymore * fixed typo * fixed some import issues * moved upload directory creation to manage.py * added some comments * moved importing app inside the only function that uses it * Update runtests.sh * added manage.py init to runtests * removed mkdir from travis config * fixed upload path issue * moar fixes to registry, cleanup, moved back to uuid4 * fixed typo * setting test environment variable in travis file * setting env in existing block, otherwise it gets overwritten * moved the init command out of if block * rearranged travis config, cleanup of upload directory path * lot of minor fixes * using dotted relative import syntax everywhere, added tests for registry(redis) * cleaning up queries and imports * cleanup of os.path and more comments on thumbnail * fixed typo * added buildspec.yml file for testing AWS CodeBuild * setting env varialbe manually for aws codebuild * removed buildspec.yml file * showing loading spinner if file is still processing

Bibhas and others added 22 commits April 7, 2017 10:17

removed celery as dependency

441629f

fixed - was missing folder name when downloading file

7337d16

handling multiple resize request for same file

ba53794

removed print statements

412e44b

if there is an error while processing a file, raise it

9a49863

fixed comment

127da69

removed all tests

be447ac

removed more unnecessary things

3b54fbd

removed unnecessary imports and minor cleanup

6cd46ce

renamed async.py

57a99f0

Merge pull request #56 from hasgeek/celery-removal

643e476

Removed celery as dependency

added label tests

9ab5a45

separating label logic

d57fec0

fixed label tests

e0f547f

more cleanup, moved some views out of index.py

cb7b9bd

cleaned up label saving codes a little

c6c4645

added tests for upload and delete

b3ff9f4

updated status code for delete test

c663086

mixed couple of migrations and showing error

e4ae277

Merge pull request #57 from hasgeek/new-tests

eb5cab0

New tests

some more cleanups

b4a14c1

Merge pull request #58 from hasgeek/new-tests

6fabf71

some more cleanups

shreyas-satish reviewed Apr 18, 2017

View reviewed changes

Bibhas added 2 commits April 18, 2017 14:26

using get_image_url to create image url

fc28fea

not showing delete label button if not logged in

edc1bf9

shreyas-satish reviewed Apr 18, 2017

View reviewed changes

Bibhas added 3 commits April 18, 2017 15:18

importing only the needed forms

95c1615

added tests for resizing files and testing with multiple file types

95adecf

comparing redirect location with generated thumbnail url

4451fb0

added redis to travis

4635676

jace reviewed Apr 25, 2017

View reviewed changes

jace requested changes May 1, 2017

View reviewed changes

Bibhas and others added 6 commits May 4, 2017 17:56

fixed conflicts

838d1ec

Merge branch 'master' of github.com:hasgeek/imgee into imgee-v2

418e080

fixed fixtures file to use new init_app behavior

f112e6c

fixed conflict

cc369e6

fixed conflict

f2c6fd6

jace mentioned this pull request Jun 27, 2017

File name along with extension used in S3 should be saved in database #69

Open

jace requested changes Jun 27, 2017

View reviewed changes

Bibhas added 3 commits June 29, 2017 14:28

lot of minor fixes

23007ec

using dotted relative import syntax everywhere, added tests for regis…

59bb581

…try(redis)

cleaning up queries and imports

d31b027

jace reviewed Jul 12, 2017

View reviewed changes

cleanup of os.path and more comments on thumbnail

ff390de

iambibhas mentioned this pull request Jul 13, 2017

Better organized detection of resolution of files #74

Open

Bibhas added 5 commits July 13, 2017 14:16

fixed typo

6731ef9

added buildspec.yml file for testing AWS CodeBuild

3dcb9e5

setting env varialbe manually for aws codebuild

d2c1228

removed buildspec.yml file

88457f5

showing loading spinner if file is still processing

102e603

iambibhas merged commit e07696c into master Jul 17, 2017

iambibhas deleted the imgee-v2 branch July 17, 2017 04:37

		@@ -104,26 +115,7 @@ def utils_save_label(label_name, profile, commit=True):


		def utils_delete_label(label):
		if isinstance(label, str):

Imgee V2 #59

Imgee V2 #59

Conversation

iambibhas commented Apr 18, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jace left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jace left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jace left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iambibhas Jun 30, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jace left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iambibhas commented Apr 18, 2017 •

edited

Loading

iambibhas Jun 30, 2017 •

edited

Loading