Function name fix, using uuid1mc, time format fix, TaskRegistry fix #60

iambibhas · 2017-05-02T04:45:13Z

No description provided.

instead of assigning them to a set

jace · 2017-06-06T08:51:32Z

.travis.yml

@@ -16,11 +16,11 @@ services:
 before_script:
  - mkdir imgee/static/test_uploads
 script:
-  - nosetests --with-coverage
+  - python runtests.py


Change this to a ./runtests.sh. Copy that from hgapp's template. Basically:

#!/bin/sh export FLASK_ENV="TESTING" coverage run `which nosetests --with-timer` coverage report

jace · 2017-06-06T08:52:19Z

.travis.yml

 install:
  - sudo apt-get -qq install zlib1g-dev libfreetype6-dev liblcms1-dev libwebp-dev libjpeg-dev libpng-dev libfreetype6-dev libtiff4-dev librsvg2-dev ghostscript imagemagick pandoc
  - pip install -r requirements.txt
-  - pip install nose coverage BeautifulSoup4 Pillow
+  - pip install nose coverage


Add these to a test_requirements.txt and use pip install -r test_requirements.txt

jace · 2017-06-06T08:55:00Z

imgee/storage.py

@@ -29,17 +29,23 @@ def get_resized_image(img, size, is_thumbnail=False):
    """
    registry = imgee.registry
    img_name = img.name
+
+    if img.mimetype == 'image/gif':
+        # if the gif file is animated, no need to resize


Actually we do need to resize with animation, but if this is non-trivial, file a ticket for this to be addressed separately. (Preserving animation is higher priority than resizing.)

Filed as #55.

jace · 2017-06-06T08:57:13Z

imgee/storage.py

+
+    if img.mimetype == 'image/gif':
+        # if the gif file is animated, no need to resize
+        src_path = download_from_s3(img.name + img.extn)


Does img.extn include a period? If so, it seems a bit redundant to store a period in the database.

It does include the period. and the period is stored in db too. and .extn is a function property https://github.com/hasgeek/imgee/blob/master/imgee/models/stored_file.py#L58

jace · 2017-06-06T08:58:21Z

imgee/storage.py

@@ -121,7 +125,7 @@ def save_on_s3(filename, remotename='', content_type='', bucket='', folder=''):
        headers = {
            'Cache-Control': 'max-age=31536000',  # 60*60*24*365
            'Content-Type': get_file_type(fp, filename),
-            'Expires': datetime.now() + timedelta(days=365)
+            'Expires': str(datetime.utcnow() + timedelta(days=365))


Does this output in the correct format for an Expires header?

It does. Passing datetime object like it was before also worked. The boto library converted it to string itself.

Okay, these are S3 headers, not HTTP headers. Makes sense.

If Boto works with datetimes, I'll say just pass that in and don't bother about casting to string.

jace · 2017-06-06T09:09:27Z

imgee/tasks.py


    def get_all_keys(self):
-        return list(self.connection.smembers(self.key))
+        # >> KEYS imgee:registry:default:*
+        return self.connection.keys(self._make_key("*"))


Single quotes

jace · 2017-06-06T09:09:39Z

imgee/tasks.py

+
+    def keys_starting_with(self, query):
+        # >> KEYS imgee:registry:default:query*
+        return self.connection.keys(self._make_key("{}*".format(query)))


Single quotes and query validation.

jace · 2017-06-06T09:11:32Z

imgee/tasks.py

+    def remove_keys_matching(self, query):
+        keys = self.search(query)
+        for k in keys:
+            self.remove_by_key(k)


Use a Redis pipe and push all commands at once, unless there's a way to do a wildcard remove directly in Redis.

jace · 2017-06-06T09:11:47Z

imgee/tasks.py

+    def remove_keys_starting_with(self, query):
+        keys = self.keys_starting_with(query)
+        for k in keys:
+            self.remove_by_key(k)


Use a pipe.

jace · 2017-06-06T09:11:56Z

imgee/tasks.py

+
+    def remove_all(self):
+        for k in self.get_all_keys():
+            self.remove_by_key(k)


jace · 2017-06-06T11:09:19Z

imgee/storage.py

@@ -216,7 +222,7 @@ def resize_and_save(img, size, is_thumbnail=False):
    Get the original image from local disk cache, download it from S3 if it misses.
    Resize the image and save resized image on S3 and size details in db.
    """
-    src_path = download_frm_s3(img.name + img.extn)
+    src_path = download_from_s3(img.filename)


Just noticed this is for download. Since img.extn is calculated, does this mean we're not actually saving the exact filename as stored in S3? That is a problem.

We are storing the the filename as stored in S3. I'm not sure why this function exists https://github.com/hasgeek/imgee/blob/master/imgee/utils.py#L88

if the file name is abcd.png, in db, we're storing name=abcd, orig_extn=.png

Oh, I get it. We're not storing the exact name in s3 in db. orig_extn is the original extension of the file. but as the thumbnail extension can be different from original extension, that target extension is stored in the ALLOWED_MIMETYPES dict, and taken from there every time we request for the extension.

Filed as #69.

jace · 2017-06-06T11:15:52Z

imgee/tasks.py


    def search(self, query):
-        return filter(lambda k: str(query) in k, self.connection.smembers(self.key))
+        # >> KEYS imgee:registry:default:*query*
+        if not re.compile(self.filename_pattern).match(query):


Compilation is pointless at runtime. You'll get the exact same performance using re.match(self.filename_pattern, query). Move the regex compilation to the module level, and move the sanity check into an independent function so you can call it anywhere you're accepting a query.

Also, abort with a custom exception instead of returning list(). This error should never occur as you're not passing in untrusted user input, so if it somehow does happen, you want it showing up in the server error log.

jace · 2017-06-06T11:34:58Z

imgee/utils.py

@@ -4,15 +4,16 @@
 import os.path
 from subprocess import check_output, CalledProcessError
 from urlparse import urljoin
-from uuid import uuid4

 from boto import connect_s3
 from boto.s3.bucket import Bucket
 from boto.s3.key import Key
 import defusedxml.cElementTree as elementtree
 from flask import request
 import magic


If magic is a Python standard lib, it should be imported above, before third party libs.

it's from a 3rd party lib python-magic. https://github.com/ahupp/python-magic

jace · 2017-06-06T11:35:29Z

imgee/utils.py


+from coaster.utils import uuid1mc
 import imgee


What's this import for?

imgee.storage.get_resized_image() was being used somewhere below. Fixing by just importing that function instead of the whole module.

jace · 2017-06-06T11:37:59Z

imgee/storage.py

@@ -29,17 +29,23 @@ def get_resized_image(img, size, is_thumbnail=False):
    """
    registry = imgee.registry


This is a circular import. Can you possibly define the registry before other modules are imported, to avoid the circular import?

One way is to move the registry's __init__ code into a distinct init_app method and call that separately after the app is configured (__init__ should also take an optional app parameter and if present call init_app).

So, an init_app() function in the tasks.py (where TaskRegistry exists), and initialize the registry there and assign it to let's say app.registry, and call it from imgee/__init__.py so that it can be used from anywhere?

No, an init_app method on the class. Not in the module.

Also, the convention in Flask is that if you want to add something to the app, add it under app.extensions (a dictionary). We already have app.extensions['lastuser']. You could do app.extensions['taskregistry']. I will not recommend this however as the task registry is specific to Imgee and is not a shared extension. It's better being referenced as a direct Python import.

jace

More comments. :-)

jace · 2017-06-07T11:19:59Z

imgee/__init__.py

@@ -48,4 +44,6 @@ def error403(error):
    app.config['MEDIA_DOMAIN'] = app.config['MEDIA_DOMAIN'].split(':', 1)[1]
 mkdir_p(app.config['UPLOADED_FILES_DEST'])


Just noticed this mkdir call. The should be in manage.py as say manage.py init. It should not be a runtime check.

jace · 2017-06-07T11:22:43Z

imgee/storage.py

@@ -29,17 +29,23 @@ def get_resized_image(img, size, is_thumbnail=False):
    """
    registry = imgee.registry


Also, the convention in Flask is that if you want to add something to the app, add it under app.extensions (a dictionary). We already have app.extensions['lastuser']. You could do app.extensions['taskregistry']. I will not recommend this however as the task registry is specific to Imgee and is not a shared extension. It's better being referenced as a direct Python import.

jace · 2017-06-07T11:23:52Z

imgee/storage.py

@@ -29,17 +29,23 @@ def get_resized_image(img, size, is_thumbnail=False):
    """
    registry = imgee.registry
    img_name = img.name
+
+    if img.mimetype == 'image/gif':
+        # if the gif file is animated, no need to resize


Filed as #55.

jace · 2017-06-07T11:27:36Z

imgee/storage.py

@@ -121,7 +125,7 @@ def save_on_s3(filename, remotename='', content_type='', bucket='', folder=''):
        headers = {
            'Cache-Control': 'max-age=31536000',  # 60*60*24*365
            'Content-Type': get_file_type(fp, filename),
-            'Expires': datetime.now() + timedelta(days=365)
+            'Expires': str(datetime.utcnow() + timedelta(days=365))


If Boto works with datetimes, I'll say just pass that in and don't bother about casting to string.

jace · 2017-06-07T11:28:09Z

imgee/storage.py

@@ -216,7 +222,7 @@ def resize_and_save(img, size, is_thumbnail=False):
    Get the original image from local disk cache, download it from S3 if it misses.
    Resize the image and save resized image on S3 and size details in db.
    """
-    src_path = download_frm_s3(img.name + img.extn)
+    src_path = download_from_s3(img.filename)


Filed as #69.

jace · 2017-06-07T11:31:41Z

imgee/storage.py

+    registry = imgee.registry
+
+    # remove from registry
+    registry.remove_keys_starting_with(stored_file.name)


Shouldn't it be …:<name>:*? The lack of a separator is asking for future accidents.

jace · 2017-06-07T11:32:28Z

imgee/storage.py

+
+    # remove from registry
+    registry.remove_keys_starting_with(stored_file.name)
+
    # remove locally
    cache_path = app.config.get('UPLOADED_FILES_DEST')
    cached_img_path = os.path.join(cache_path, '%s*' % stored_file.name)


Likewise here. Shouldn't there be an underscore separator?

jace

You're good after these changes.

jace · 2017-06-21T07:32:07Z

.travis.yml

 script:
-  - nosetests --with-coverage
+  - ./runtests.sh
 install:
  - sudo apt-get -qq install zlib1g-dev libfreetype6-dev liblcms1-dev libwebp-dev libjpeg-dev libpng-dev libfreetype6-dev libtiff4-dev librsvg2-dev ghostscript imagemagick pandoc


Where have these dependencies gone?

What do you mean?

This line has been removed. Don't we need these libraries anymore?

Umm. It's not been removed. They are there.

imgee/.travis.yml

Line 21 in e7f46fa

- sudo apt-get -qq install zlib1g-dev libfreetype6-dev liblcms1-dev libwebp-dev libjpeg-dev libpng-dev libfreetype6-dev libtiff4-dev librsvg2-dev ghostscript imagemagick pandoc

jace · 2017-06-21T07:33:00Z

imgee/__init__.py


 # Configure the app
 coaster.app.init_app(app)
 migrate = Migrate(app, db)
 baseframe.init_app(app, requires=['baseframe', 'picturefill', 'imgee'])
 lastuser.init_app(app)
 lastuser.init_usermanager(UserManager(db, models.User))
+registry.init_app()


This is supposed to get app as a parameter. It shouldn't import the app.

jace · 2017-06-21T07:33:41Z

imgee/__init__.py

+# using it to determine the project root
+# either get it from environment variable, or it's one level up from this init file
+app.project_root = os.environ.get('PYTHONPATH', '') or os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
+print app.project_root


Remove these two lines. They should be in the test script, not in code that runs in production.

jace · 2017-06-21T07:35:12Z

imgee/__init__.py

@@ -46,6 +47,3 @@ def error403(error):
        app.config['MEDIA_DOMAIN'].startswith('http:') or
        app.config['MEDIA_DOMAIN'].startswith('https:')):


Replace this if condition with if app.config.get('MEDIA_DOMAIN', '').lower().startswith(('http://', 'https://'))

jace · 2017-06-21T07:41:31Z

imgee/tasks.py

+        if app:
+            self.init_app(name, connection)
+
+    def init_app(self, name='default', connection=None):


init_app should not take any parameters apart from app. The other parameters go directly to __init__.

Set self.app = app here.

jace · 2017-06-21T07:46:33Z

imgee/utils.py

@@ -84,7 +84,7 @@


 def newid():
-    return unicode(uuid4().hex)
+    return unicode(uuid1mc().hex)


Back to uuid4

jace · 2017-06-21T07:47:22Z

imgee/utils.py

@@ -97,7 +97,7 @@ def get_file_url(scheme=None):


 def path_for(img_name):
-    return os.path.join(app.config['UPLOADED_FILES_DEST'], img_name)
+    return os.path.join(app.project_root, app.config['UPLOADED_FILES_DEST'], img_name)


Don't use this. If files are hosted under the static folder, use app.static_folder

jace · 2017-06-21T07:49:07Z

manage.py

+
+    @manager.command
+    def init():
+        mkdir_p(os.path.join(app.project_root, app.config['UPLOADED_FILES_DEST']))


Move this command outside the if clause.

but manager is defined inside the if block.

Add from coaster.manage import manager at the top. init_manager just returns the same manager. You can discard its return value and use the imported manager.

jace · 2017-06-21T07:50:01Z

runtests.sh

+#!/bin/sh
+set -e
+export FLASK_ENV="TESTING"
+export PYTHONPATH=$(pwd)  # setting project root as PYTHONPATH


Use $(dirname $0) here, since runtests.sh could be called from another folder.

jace · 2017-06-21T07:50:50Z

runtests.sh

+set -e
+export FLASK_ENV="TESTING"
+export PYTHONPATH=$(pwd)  # setting project root as PYTHONPATH
+./manage.py init  # creates the test upload directory


Move this line to .travis.yml, It's part of the install steps, not the test running steps.

jace · 2017-06-23T04:07:23Z

.travis.yml

  - pip install -r requirements.txt
-  - pip install nose coverage BeautifulSoup4 Pillow
+  - pip install -r test_requirements.txt


Just a comment on the order of sections, to make this file more readable. It should be in install, before_script, script order.

jace · 2017-06-23T04:11:03Z

imgee/storage.py

    """
-    cache_path = app.config.get('UPLOADED_FILES_DEST')
+    cache_path = os.path.join(app.static_folder, app.config.get('UPLOADED_FILES_DIR'))


os.path.join will break out of app.static_folder if the config setting has .. or / in it. I recall there's a secure version of path.join that checks for this. Investigate it? (Not particularly serious though since it's only in server-side config.)

I'll check this out and make changes when I find it.

jace · 2017-06-23T04:16:18Z

imgee/tasks.py

-        self.key = 'imgee:registry:%s' % name
+        self.connection = connection
+        self.key_prefix = 'imgee:registry:%s' % name
+        self.filename_pattern = '^[a-z0-9\_\.]+$'


Did you mean to use re.compile(r'^[a-z0-9_\.]+$')? It needs to be a raw r string to remove ambiguity around the \, and the . needs escaping in regex, but not _.

making it a raw string and not escaping _. And we dont need to compile because as you mentioned before, no point compiling during runtime. passing the pattern directly to re.match().

jace · 2017-06-23T04:17:30Z

imgee/tasks.py



 class TaskRegistry(object):
-    def __init__(self, name='default', connection=None):
-        self.connection = redis.from_url(connection) if connection else None
+    def __init__(self, name='default', connection=None, app=None):


Usually app is the first parameter after self.

jace · 2017-06-23T04:20:54Z

imgee/utils.py

@@ -238,11 +248,12 @@ def get_no_previews_url(size):


 def get_image_url(image, size=None):
+    from imgee import storage


Let's find a way to avoid importing inside functions. It should be the last resort.

This one is a circular import issue. storage.py imports a hell lot of stuff from this file but this file needs just one function from storage.py. hence importing here, only where it's needed.

jace · 2017-06-23T04:21:39Z

instance/settings.py

@@ -34,6 +34,7 @@
 LOGFILE = 'error.log'
 #: File uploads
 UPLOADED_FILES_DEST = 'imgee/static/uploads'


Does this config value still need to be present?

No. forgot to delete this.

jace · 2017-06-23T04:23:03Z

instance/settings.py

@@ -34,6 +34,7 @@
 LOGFILE = 'error.log'
 #: File uploads
 UPLOADED_FILES_DEST = 'imgee/static/uploads'
+UPLOADED_FILES_DIR = 'uploads'  # this folder should be inside `imgee/static/`
 #: S3 Configuration
 AWS_ACCESS_KEY = 'Set aws access key here'
 AWS_SECRET_KEY = 'Set aws secret key here'


We don't want to encourage inserting values into a file that's version controlled in git. Maybe this file should be named settings-sample.py.

settings.py should be gitignored?

jace · 2017-06-23T04:25:29Z

manage.py

+
+@manager.command
+def init():
+    mkdir_p(os.path.join(app.static_folder, app.config['UPLOADED_FILES_DIR']))


This os.path.join call is in two places now. Best if it was in a function that's imported in both places.

jace · 2017-06-23T04:27:16Z

tests/fixtures.py

+        # PYTHONPATH is `pwd` when testing and empty otherwise
+        # using it to determine the project root
+        # either get it from environment variable, or it's one level up from this init file
+        app.project_root = os.environ.get('PYTHONPATH', '') or os.path.dirname(os.path.dirname(os.path.abspath(__file__)))


PYTHONPATH is a path and can potentially contain multiple semicolon-separated entries. Best to use the dirname method you have here and use that alone.

Since you're able to import imgee, do a dirname on the imgee module instead of on __file__. Also, why is this variable being added to the app object? Where is it used?

Don't need this actually. removing it.

* removed celery as dependency * fixed - was missing folder name when downloading file * handling multiple resize request for same file * removed print statements * if there is an error while processing a file, raise it * fixed comment * removed all tests * removed more unnecessary things * removed unnecessary imports and minor cleanup * renamed async.py * added label tests * separating label logic * fixed label tests * more cleanup, moved some views out of index.py * cleaned up label saving codes a little * added tests for upload and delete * updated status code for delete test * mixed couple of migrations and showing error * some more cleanups * using get_image_url to create image url * not showing delete label button if not logged in * importing only the needed forms * added tests for resizing files and testing with multiple file types * comparing redirect location with generated thumbnail url * added redis to travis * fixed fixtures file to use new init_app behavior * Function name fix, using uuid1mc, time format fix, TaskRegistry fix (#60) * function name fix, using uuid1mc, time format fix * deleting keys from registry when deleting a file * restructured TaskRegistry to use Redis Keys with TTL set to 60 seconds instead of assigning them to a set * re-adding nose and coverage to travis file, removed it by mistake * using runtests.py file to run tests in travis * reordered functions and better string formating * made the redis key expiry time an argument * assigning error handler the right way * not resizing if the gif image is animated * added pillow as dependency * using redis pipeline to delete multiple keys * missed one place to use redis pipeline * deleted runtests.py, not needed anymore * fixed typo * fixed some import issues * moved upload directory creation to manage.py * added some comments * moved importing app inside the only function that uses it * Update runtests.sh * added manage.py init to runtests * removed mkdir from travis config * fixed upload path issue * moar fixes to registry, cleanup, moved back to uuid4 * fixed typo * setting test environment variable in travis file * setting env in existing block, otherwise it gets overwritten * moved the init command out of if block * rearranged travis config, cleanup of upload directory path * lot of minor fixes * using dotted relative import syntax everywhere, added tests for registry(redis) * cleaning up queries and imports * cleanup of os.path and more comments on thumbnail * fixed typo * added buildspec.yml file for testing AWS CodeBuild * setting env varialbe manually for aws codebuild * removed buildspec.yml file * showing loading spinner if file is still processing

Bibhas added 6 commits May 2, 2017 10:12

function name fix, using uuid1mc, time format fix

152c153

deleting keys from registry when deleting a file

039cdbd

Merge branch 'imgee-v2' of github.com:hasgeek/imgee into code-review

2f5df3b

restructured TaskRegistry to use Redis Keys with TTL set to 60 seconds

6b8e07f

instead of assigning them to a set

re-adding nose and coverage to travis file, removed it by mistake

221dcde

using runtests.py file to run tests in travis

ede59b9

iambibhas changed the title ~~Function name fix, using uuid1mc, time format fix~~ Function name fix, using uuid1mc, time format fix, TaskRegistry fix May 9, 2017

Bibhas added 7 commits May 11, 2017 11:47

reordered functions and better string formating

dfdf09a

made the redis key expiry time an argument

df77ffc

assigning error handler the right way

2d7ff92

not resizing if the gif image is animated

95dce28

added pillow as dependency

5cead4e

fixed conflict

d6766a7

Merge branch 'imgee-v2' into code-review

b5906f9

jace requested changes Jun 6, 2017

View reviewed changes

iambibhas mentioned this pull request Jun 6, 2017

If gif file is animated, resize keeping animation intact #55

Open

Bibhas added 4 commits June 6, 2017 15:30

using redis pipeline to delete multiple keys

7a5bcb9

missed one place to use redis pipeline

28e656f

deleted runtests.py, not needed anymore

83128dd

fixed typo

144d4ac

jace reviewed Jun 6, 2017

View reviewed changes

jace requested changes Jun 6, 2017

View reviewed changes

jace requested changes Jun 7, 2017

View reviewed changes

Bibhas and others added 7 commits June 8, 2017 14:14

fixed some import issues

dc961d6

moved upload directory creation to manage.py

907c7fe

added some comments

a1372fb

moved importing app inside the only function that uses it

127aa4c

Update runtests.sh

e3228e4

Update runtests (testing jenkins)

3ca82e9

testing jenkins

b581138

Bibhas and others added 12 commits June 15, 2017 22:33

removed pinned versions

395b862

testing jenkins

85b505c

test jenkins

9d17938

testing jenkins

e42e750

testing jenkins

fd8737c

added manage.py init to runtests

0cc523e

removed mkdir from travis config

64da948

trying to fix travis build

eeb5b96

trying to fix travis build

81ccc8d

trying to debug travis

7a71a7a

trying to fix travis build

f2b4b26

fixed upload path issue

154b23c

jace requested changes Jun 21, 2017

View reviewed changes

Bibhas added 5 commits June 21, 2017 15:51

moar fixes to registry, cleanup, moved back to uuid4

e7f46fa

fixed typo

5ceb68c

setting test environment variable in travis file

bb6a350

setting env in existing block, otherwise it gets overwritten

78bd8d3

moved the init command out of if block

993287c

jace requested changes Jun 23, 2017

View reviewed changes

rearranged travis config, cleanup of upload directory path

481701a

iambibhas merged commit 380bb87 into imgee-v2 Jun 23, 2017

iambibhas deleted the code-review branch June 23, 2017 05:29

		@@ -29,17 +29,23 @@ def get_resized_image(img, size, is_thumbnail=False):
		"""
		registry = imgee.registry

		@@ -48,4 +44,6 @@ def error403(error):
		app.config['MEDIA_DOMAIN'] = app.config['MEDIA_DOMAIN'].split(':', 1)[1]
		mkdir_p(app.config['UPLOADED_FILES_DEST'])

		@@ -46,6 +47,3 @@ def error403(error):
		app.config['MEDIA_DOMAIN'].startswith('http:') or
		app.config['MEDIA_DOMAIN'].startswith('https:')):

		@@ -238,11 +248,12 @@ def get_no_previews_url(size):


		def get_image_url(image, size=None):
		from imgee import storage

Function name fix, using uuid1mc, time format fix, TaskRegistry fix #60

Function name fix, using uuid1mc, time format fix, TaskRegistry fix #60

Conversation

iambibhas commented May 2, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jace Jun 6, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iambibhas Jun 6, 2017 • edited Loading

Choose a reason for hiding this comment

jace Jun 6, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jace left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jace left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jace Jun 6, 2017 •

edited

Loading

iambibhas Jun 6, 2017 •

edited

Loading

jace Jun 6, 2017 •

edited

Loading