update pallets #12
Merged
update pallets #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#10) * - Updated the Fund Admin Records' list of dependencies in Cargo.toml, bumping versions of 'frame support', 'frame system', 'frame benchmarking', 'sp runtime', 'pallet timestamp', 'sp core' and 'sp io' to be compatible with 'polkadot-v0.9.40' from 'polkadot-v0.9.38', aligning with the latest Substrate version. This ensures our pallets stay up-to-date with the latest turnkey infrastructure enabling efficient blockchain development. - Amended the weight ranges for three different calls - 'set_signer_account', 'add_record', and 'kill_storage' - within the Fund Admin Records pallet. We've changed the implementation to 'from_parts', explicitly setting the 'compute' part of the weight to 10,000 and 'io' part to 0. This provides a more specific weight range, optimizing on-chain resource use when these calls are processed. * DEVELOPMENT AND TROUBLESHOOTING - Updated the `pallet` macro for the Fund Admin Records pallet, specifying `STORAGE_VERSION` for better versioning control of the storage data. This ensures proper migration handling in future updates. - Commented out certain test function bodies in the Fund Admin Records pallet. This indicates an ongoing refactoring process and tests will be revisited to ensure they align with the new implementation specifics. - Updated the `pallet_rbac` configuration in the mock file of the Fund Admin pallet, adding `RemoveOrigin` set to `EnsureRoot<Self::AccountId>` to ensure that function calls, specific to the RBAC functionality, are executed by verified roots. - Carried out codebase clean-up in the Gated Marketplace pallet, removing unneeded imports and fixing an incorrect closing tag on the `Config` implementation block. - Updated the test suite for the Gated Marketplace pallet. Ensured that the `mint` function placing assets in the marketplace is correctly unwrapped using `assert_ok`. Commented out certain test cases, indicating a significant refactoring process which the tests will be revisited to align with. - Adjusted the properties order in the pallet-rbac dependency within the Mapped Assets pallet's Cargo.toml for consistency and readability. - Set up RBAC pallet in the test environment for the Mapped Assets pallet, implementing specific parameter types and configuring RBAC pallet for the test setup. - Updated the test suite for the RBAC pallet. Several test cases were commented out indicating an ongoing refactoring process which the tests will be revisited to align with.
* 🐛 fix(afloat): modify `kill_storage` function to accept `args` parameter for more granular control over storage deletion ✨ feat(afloat): add `KillStorageArgs` enum to specify different types of storage to be deleted in `kill_storage` function * 🐛 fix(functions.rs): add authorization check in do_cancel_offer function to ensure only admin or offer creator can cancel the offer 🐛 fix(lib.rs): remove redundant authorization check in cancel_offer function
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -390,15 +390,6 @@ dependencies = [ | |||
| "libc", | |||
| @@ -859,11 +859,14 @@ impl<T: Config> Pallet<T> { | |||
| Ok(()) | |||
There was a problem hiding this comment.
GPT summary of c00078 - 10b75e:
- Changed the signature of
do_cancel_offer()to include anAccountIdargument - Added a check to ensure that the caller is either an admin or the owner of the offer
- Added a check to ensure that the offer exists
- Added a check to ensure that the offer status is
CREATEDbefore attempting to cancel
| @@ -255,11 +255,40 @@ pub mod pallet { | |||
|
|
|||
| @@ -161,6 +161,17 @@ pub enum CreateOfferArgs<T: Config> { | |||
| }, | |||
| @@ -20,15 +20,15 @@ codec = { package = "parity-scale-codec", version = "3.0.0", default-features = | |||
| scale-info = { version = "2.0.1", default-features = false, features = [ | |||
| @@ -22,6 +22,7 @@ pub mod pallet { | |||
| use frame_support::traits::Time; | |||
There was a problem hiding this comment.
GPT summary of 937974 - c6aced:
- Added a constant
STORAGE_VERSION - Updated pallet annotation to include
storage_version - Updated weight annotations to use
Weight::from_parts - Added a function
set_signer_accountto set the account id of the signer - Added a function
add_recordto add a record to the storage - Added a function
kill_storageto clear the storage
| @@ -1,5 +1,5 @@ | |||
| use crate::{mock::*, types::*, Records, Error}; | |||
| @@ -148,6 +148,7 @@ parameter_types! { | |||
| } | |||
| @@ -1,6 +1,6 @@ | |||
| use crate as pallet_gated_marketplace; | |||
| @@ -756,7 +756,7 @@ fn add_authority_admin_works() { | |||
| 600, | |||
| @@ -25,7 +25,7 @@ frame-support = { git = "https://github.com/paritytech/substrate", branch = "pol | |||
| # `system` module provides us with all sorts of useful stuff and macros depend on it being around. | |||
There was a problem hiding this comment.
| @@ -31,6 +31,7 @@ use sp_runtime::{ | |||
| testing::Header, | |||
| @@ -838,16 +838,6 @@ fn tx_create_and_set_roles_should_work() { | |||
| }); | |||
There was a problem hiding this comment.
GPT summary of 9745a3 - a73e8c:
- Removed tests for tx_create_and_set_roles_while_not_root_should_fail() and tx_remove_role_from_user_while_not_root_should_fail()
- Updated tests for tx_create_and_set_permissions_while_not_root_should_fail(), tx_assing_role_to_user_while_not_root_should_fail(), and tx_remove_role_from_user_should_work()
- Added tests for tx_create_and_set_roles_should_work() and tx_assing_role_to_user_should_work()
|
GPT summary of a8d1072: Error: couldn't generate summary |
|
GPT summary of 2a16ce2:
PR summary so far:
|
* 🐛 fix(afloat): modify `kill_storage` function to accept `args` parameter for more granular control over storage deletion ✨ feat(afloat): add `KillStorageArgs` enum to specify different types of storage to be deleted in `kill_storage` function * 🐛 fix(functions.rs): add authorization check in do_cancel_offer function to ensure only admin or offer creator can cancel the offer 🐛 fix(lib.rs): remove redundant authorization check in cancel_offer function
|
GPT summary of aa5f5ab:
PR summary so far:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added parameters to do_cancel_offer and kill_storage functions
Added KillStorageArgs enum
Added set_signer_account and add_record functions to fund-admin-records pallet
Added RemoveOrigin type to pallet_rbac::Config for Test
Updated weight annotations to use Weight::from_parts