-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing permissions in afloat #18
Conversation
… ensure consistency with admin role assignment ✨ feat(lib.rs): add support for adding afloat and frunique roles during initial setup 🔧 chore(types.rs): add AddAfloatRole and AddFruniqueRole variants to InitialSetupArgs enum for role assignment
…at_frunique function call 🔧 chore(types): import FruniqueRole from pallet_fruniques to fix type error in InitialSetupArgs
@@ -856,6 +856,8 @@ impl<T: Config> Pallet<T> { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPT summary of ee955a - 4c39a1:
- Added a
give_role_to_user()
function to give a user an AfloatRole of Admin - Added a
do_add_account_to_afloat_frunique()
function to add an account to AfloatFrunique with a FruniqueRole of Admin - Added an event to deposit an
AdminAdded
event with the authority and user address
@@ -223,6 +223,14 @@ pub mod pallet { | |||
Self::do_setup_roles(creator, admin)?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1,5 +1,6 @@ | |||
use super::*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPT summary of e04677f:
|
GPT summary of a6d2855:
PR summary so far:
|
…pallet` module The `spam_spawning` function was commented out and not being used. Removing it to improve code cleanliness and readability.
@@ -509,19 +509,5 @@ pub mod pallet { | |||
T::Rbac::remove_pallet_storage(Self::pallet_id())?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR summary so far:
AddAfloatRole
andAddFruniqueRole
variants to theInitialSetupArgs
enumAddFruniqueRole
fromAfloatRole
toFruniqueRole
spam_spawning