-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies to use Polkadot v1.0.0 #19
Conversation
…r frame-support, frame-system, frame-benchmarking, sp-core, sp-io, sp-runtime, and sp-std 🚀 chore(bitcoin-vaults): update dependencies to use Polkadot v1.0.0 branch for frame-support, frame-system, frame-benchmarking, sp-core, sp-io, sp-runtime, and sp-std 🚀 chore(confidential-docs): update dependencies to use Polkadot v1.0.0 branch for frame-support, frame-system, and frame-benchmarking 🔀 chore(Cargo.toml): update substrate dependencies to use polkadot-v1.0.0 branch for fruniques, fund-admin-records, and fund-admin pallets 🔀 chore(Cargo.toml): update dependencies to use polkadot-v1.0.0 branch for frame-support, frame-system, frame-benchmarking, sp-runtime, pallet-uniques, pallet-balances, pallet-timestamp, sp-core, sp-io, and pallet-balances in gated-marketplace, mapped-assets, and rbac pallets 🔀 chore(Cargo.toml): update substrate dependencies to use polkadot-v1.0.0 branch for frame-support, frame-system, frame-benchmarking, sp-std, sp-core, sp-io, and sp-runtime to align with the latest version of Substrate framework
@@ -734,7 +734,7 @@ dependencies = [ | |||
[[package]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -21,23 +21,23 @@ serde = { version = "1.0.140", default-features = false, features = ["derive"] } | |||
scale-info = { version = "2.1.1", default-features = false, features = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPT summary of 34a988 - d236c4:
- Updated version of serde, scale-info, frame-support, frame-system, frame-benchmarking, sp-runtime, pallet-uniques, pallet-balances, pallet-timestamp, pallet-fruniques, pallet-rbac, pallet-gated-marketplace, and pallet-mapped-assets from polkadot-v0.9.40 to polkadot-v1.0.0.
- Updated version of sp-core, sp-io, sp-runtime, and sp-std from polkadot-v0.9.40 to polkadot-v1.0.0.
@@ -22,17 +22,17 @@ lite-json = { version = "0.1", default-features = false } | |||
scale-info = { version = "2.1.1", default-features = false, features = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -19,14 +19,14 @@ codec = { package = "parity-scale-codec", version = "3.0.0", default-features = | |||
scale-info = { version = "2.1.1", default-features = false, features = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -20,17 +20,17 @@ codec = { package = "parity-scale-codec", version = "3.0.0", default-features = | |||
scale-info = { default-features = false, version = "2.0.1", features = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPT summary of ef440b - d76a5a:
- Updated the version of codec to 3.0.0
- Updated the version of scale-info to 2.0.1
- Updated the versions of frame-support, frame-system, frame-benchmarking, sp-runtime, pallet-uniques, and pallet-balances to polkadot-v1.0.0
- Updated the version of sp-core to 7.0.0
- Updated the versions of sp-io to polkadot-v1.0.0
@@ -20,15 +20,15 @@ codec = { package = "parity-scale-codec", version = "3.0.0", default-features = | |||
scale-info = { version = "2.0.1", default-features = false, features = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -20,17 +20,17 @@ codec = { package = "parity-scale-codec", version = "3.0.0", default-features = | |||
scale-info = { version = "2.0.1", default-features = false, features = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -21,21 +21,21 @@ serde = { version = "1.0.140", default-features = false, features = ["derive"] } | |||
scale-info = { version = "2.1.1", default-features = false, features = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -17,21 +17,21 @@ codec = { package = "parity-scale-codec", version = "3.0.0", default-features = | |||
scale-info = { version = "2.1.1", default-features = false, features = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -20,14 +20,14 @@ codec = { package = "parity-scale-codec", version = "3.0.0", default-features = | |||
scale-info = { version = "2.1.1", default-features = false, features = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPT summary of 8fdf06 - 23cb28:
- Updated the version of
parity-scale-codec
to3.0.0
- Updated the version of
scale-info
to2.1.1
- Updated the version of
frame-support
,frame-system
,frame-benchmarking
, andsp-runtime
frompolkadot-v0.9.40
topolkadot-v1.0.0
- Updated the version of
sp-core
andsp-io
frompolkadot-v0.9.40
topolkadot-v1.0.0
@@ -20,16 +20,16 @@ log = { version = "0.4.14", default-features = false } | |||
scale-info = { version = "2.1.1", default-features = false, features = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPT summary of f27123 - 85df99:
- Updated versions of the following crates to
polkadot-v1.0.0
branch:frame-support
,frame-system
,frame-benchmarking
,sp-std
,sp-core
,sp-io
, andsp-runtime
- Updated version of
log
crate to0.4.14
- Updated version of
scale-info
crate to2.1.1
- Added
derive
feature toscale-info
crate - Updated default feature of
default
crate tostd
GPT summary of baf7428: Error: couldn't generate summary PR summary so far:
|
… for better readability 🔧 chore(rust-toolchain.toml): update Rust toolchain channel to nightly-2023-10-01 for compatibility with dependencies and add rustfmt component
@@ -127,12 +127,12 @@ pub mod v1 { | |||
current_version.put::<Pallet<T>>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPT summary of be16e32:
PR summary so far:
|
@@ -64,7 +64,7 @@ impl<T: Config> Pallet<T> { | |||
AfloatCollectionId::<T>::put(collection_id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPT summary of 4c39a1 - 037753:
- Changed return type of
create_fruniques_collection
fromOk(())
toErr(Error::FailedToCreateFruniquesCollection)
- Changed comparison operator in
do_purchase_tax_credit
from>=
to>
- Added semicolon to
do_purchase_tax_credit
afterErr(Error::NotEnoughAfloatBalanceAvailable)
- Added semicolon to
do_purchase_tax_credit
afterErr(Error::TaxCreditAmountOverflow)
- Added semicolon to
do_purchase_tax_credit
afterErr(Error::Underflow)
@@ -33,7 +33,7 @@ impl<T: Config> Pallet<T> { | |||
vault_members.clone().into_iter().try_for_each(|acc| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPT summary of a963f9 - 046dcc:
- Added a check for the existence of an xpub when creating a vault
- Updated an error message for when a signer does not have permission to finalize a proposal
- Added a check to determine if an xpub is available for registration
- Updated a check to determine if a vault can be finalized
- Updated an error message for when a request fails
- Updated an error message for when a server error occurs
@@ -279,7 +279,7 @@ pub mod pallet { | |||
// transactions without it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -117,8 +117,8 @@ impl<T: Config> GroupMember<T> { | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -62,7 +62,7 @@ impl<T: Config> Pallet<T> { | |||
) -> AttributeValue<T> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -341,7 +341,7 @@ pub mod pallet { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -43,10 +43,10 @@ pub struct ParentInfo<T: Config> { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1606,8 +1606,8 @@ impl<T: Config> Pallet<T> { | |||
DrawdownsInfo::<T>::get(drawdown_id).ok_or(Error::<T>::DrawdownNotFound)?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPT summary of 5faf71 - 5ad228:
- Changed the way the roles of users are checked when assigning them to projects
- Updated error messages when trying to assign an administrator role account to a project
- Changed the way the status of drawdowns and revenues are checked when performing certain actions
- Updated error messages when trying to perform an action on a submitted drawdown or revenue
- Updated the way the status of revenue transactions is checked when performing certain actions
- Updated error messages when trying to perform an action on a submitted revenue transaction
- Updated the logic for transferring funds to users
@@ -376,8 +376,8 @@ fn get_drawdown_id( | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPT summary of c9d233 - 51ad5c:
- Changed comparison logic in
get_drawdown_id
andget_transaction_id
functions, by removing redundant comparison statements. - Changed comparison logic in
get_revenue_transaction_id
function, by removing redundant comparison statements. - In
expenditures_add_a_hard_cost_budget_expenditure_for_a_given_project_works
,expenditures_add_a_softcost_budget_expenditure_for_a_given_project_works
,expenditures_add_an_operational_budget_expenditure_for_a_given_project_works
, andexpenditures_add_an_others_budget_expenditure_for_a_given_project_works
functions, added abreak
statement after the target expenditure is found. - In
expenditures_edit_a_given_expenditure_works
,expenditures_admnistrator_tries_to_update_a_non_existent_expenditure_should_fail
, andexpenditures_delete_a_selected_expenditure_works
functions, added abreak
statement after the target expenditure is found.
@@ -176,7 +176,7 @@ impl<T: Config> Pallet<T> { | |||
AccountOrApplication::Application(application_id) => <ApplicationsByAccount<T>>::iter() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPT summary of f6924d - ee3073:
- Changed the logic for fetching the account associated with an application
- Added a check to prevent owners from deleting themselves
- Added a check to ensure the price is valid when creating an offer
- Added a check to ensure the owner of an NFT is in the same marketplace as the caller making the offer
- Added a check to prevent approved applications from being rejected
- Changed the logic for deleting an application
- Added a check to ensure the offer type is SellOrder when creating an offer
- Added a check to ensure the owner is in the marketplace when enlisting a sell offer
- Added a check to ensure the owner is the one trying to redeem an NFT
@@ -404,8 +404,9 @@ pub mod pallet { | |||
let who = ensure_signed(origin)?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -238,8 +238,8 @@ fn apply_to_marketplace_works() { | |||
)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPT summary of e88400 - e159b7:
- Updated the logic for applying to a marketplace and enrolling in a marketplace
- Updated the logic for removing a marketplace, ensuring that the related storage is properly deleted for applicants with different statuses (pending, approved, rejected)
- Updated the logic for removing a marketplace, ensuring that the related storage is properly deleted for applications by account
@@ -150,21 +150,21 @@ impl<T: Config<I>, I: 'static> Pallet<T, I> { | |||
None => return DepositConsequence::UnknownAsset, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPT summary of 98f0c4 - e9ffaf:
- Fixed return type of DepositConsequence::Overflow, DepositConsequence::BelowMinimum, DepositConsequence::CannotCreate, DepositConsequence::Overflow, Underflow, Frozen, Success, NoFunds, Frozen
- Fixed return type of Error::UnknownAsset, TokenError::BelowMinimum
- Added check for admin permission when transferring assets
- Added check for minimum balance when transferring assets
- Added check for frozen accounts when transferring assets
- Added check for insufficient balance when transferring assets
- Fixed check for overflow when transferring assets
@@ -42,7 +42,7 @@ impl<T: Config<I>, I: 'static> StoredMap<(T::AssetId, T::AccountId), T::Extra> f | |||
if let Some(ref mut account) = maybe_account { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1159,7 +1159,7 @@ pub mod pallet { | |||
ensure!(details.status == AssetStatus::Live, Error::<T, I>::LiveAsset); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -123,7 +123,7 @@ pub enum ExistenceReason<Balance> { | |||
impl<Balance> ExistenceReason<Balance> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1,5 +0,0 @@ | |||
[toolchain] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPT summary of 4dded4c: Error: couldn't generate summary PR summary so far:
|
…r frame-support, frame-system, frame-benchmarking, sp-core, sp-io, sp-runtime, and sp-std
🚀 chore(bitcoin-vaults): update dependencies to use Polkadot v1.0.0 branch for frame-support, frame-system, frame-benchmarking, sp-core, sp-io, sp-runtime, and sp-std
🚀 chore(confidential-docs): update dependencies to use Polkadot v1.0.0 branch for frame-support, frame-system, and frame-benchmarking
🔀 chore(Cargo.toml): update substrate dependencies to use polkadot-v1.0.0 branch for fruniques, fund-admin-records, and fund-admin pallets
🔀 chore(Cargo.toml): update dependencies to use polkadot-v1.0.0 branch for frame-support, frame-system, frame-benchmarking, sp-runtime, pallet-uniques, pallet-balances, pallet-timestamp, sp-core, sp-io, and pallet-balances in gated-marketplace, mapped-assets, and rbac pallets
🔀 chore(Cargo.toml): update substrate dependencies to use polkadot-v1.0.0 branch for frame-support, frame-system, frame-benchmarking, sp-std, sp-core, sp-io, and sp-runtime to align with the latest version of Substrate framework.