fix dependencies #20
Closed
fix dependencies #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔀 chore(Cargo.toml): reformat members list for better readability and maintainability
…me and sp-core dependencies to allow for flexibility in using compatible versions 🔧 chore(Cargo.toml): remove specific version requirement for sp-runtime and sp-core dependencies to allow for flexibility in using compatible versions 🔧 chore(Cargo.toml): remove specific version requirement for sp-runtime and sp-core dependencies to allow for flexibility in using compatible versions
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -14,20 +14,20 @@ dependencies = [ | |||
|
|
|||
| @@ -1,14 +1,16 @@ | |||
| [workspace] | |||
| @@ -23,13 +23,13 @@ scale-info = { default-features = false, version = "2.0.1", features = [ | |||
| frame-support = { default-features = false, git = "https://github.com/paritytech/substrate.git", branch = "polkadot-v1.0.0" } | |||
There was a problem hiding this comment.
GPT summary of d76a5a - 2ee1e0:
- Updated
scale-info,frame-support,frame-system,frame-benchmarking,sp-runtime,pallet-uniques,pallet-balances, andpallet-rbacto use thepolkadot-v1.0.0branch from theparitytech/substraterepository. - Updated
sp-coreandsp-ioin thedev-dependenciessection to use thepolkadot-v1.0.0branch from theparitytech/substraterepository.
| @@ -23,11 +23,11 @@ scale-info = { version = "2.0.1", default-features = false, features = [ | |||
| frame-support = { default-features = false, git = "https://github.com/paritytech/substrate.git", branch = "polkadot-v1.0.0" } | |||
| @@ -23,13 +23,13 @@ scale-info = { version = "2.0.1", default-features = false, features = [ | |||
| frame-support = { default-features = false, git = "https://github.com/paritytech/substrate.git", branch = "polkadot-v1.0.0" } | |||
|
GPT summary of 50e8ae7: Error: couldn't generate summary |
|
GPT summary of cfb660d:
PR summary so far:
|
…-info crates to improve compatibility and stability 🚀 chore(Cargo.toml): update dependencies versions for frame-benchmarking, frame-support, and frame-system crates to improve compatibility and stability 🚀 chore(Cargo.toml): update dependencies versions for sp-core, sp-io, and sp-runtime crates to improve compatibility and stability 🔨 refactor(lib.rs): remove unused imports and update documentation links 🔨 refactor(lib.rs): remove unused storage item MyBytesVal and associated dispatchable insert_my_bytes 🔨 refactor(lib.rs): remove unused migrations module 🔨 refactor(lib.rs): remove unused tests module 🔨 refactor(lib.rs): remove unused benchmarking module 🔨 refactor(lib.rs): remove unused STORAGE_VERSION constant 🔨 refactor(lib.rs): remove unused Pallet struct 🔨 refactor(lib.rs): remove unused SomethingStored event parameter names 🔨 refactor(lib.rs): remove unused MyBytes type 🔨 refactor(lib.rs): remove unused Error variant parameter names 🔨 refactor(lib.rs): remove unused cause_error dispatchable weight calculation 🔨 refactor(lib.rs): remove unused do_something dispatchable weight calculation 🔨 refactor(lib.rs): remove unused do_something dispatchable origin check 🔨 refactor(lib.rs): remove unused do_something dispatchable event emission 🔨 refactor(lib.rs): remove unused do_something dispatchable storage update 🔨 refactor(lib.rs): remove unused do_something dispatchable parameter names 🔨 refactor(lib.rs): remove unused do_something dispatchable return type 🔨 refactor(lib.rs): remove unused Config trait type WeightInfo 🔨 refactor(lib.rs): remove unused Config trait type RuntimeEvent 🔨 refactor(lib.rs): remove unused Config trait 🔨 refactor(lib.rs): remove unused pallet module 🔨 refactor(mock.rs): refactor mock runtime configuration to improve readability and remove unused code 🔧 chore(mock.rs): update SS58Prefix to 42 for consistency with the network configuration
|
GPT summary of 93d00b7: Error: couldn't generate summary PR summary so far:
|
… the Rust toolchain configuration
| @@ -64,7 +64,7 @@ impl<T: Config> Pallet<T> { | |||
| AfloatCollectionId::<T>::put(collection_id); | |||
There was a problem hiding this comment.
| @@ -33,7 +33,7 @@ impl<T: Config> Pallet<T> { | |||
| vault_members.clone().into_iter().try_for_each(|acc| { | |||
There was a problem hiding this comment.
GPT summary of 046dcc - a963f9:
- Added a check for if a user has an xpub when creating a vault
- Updated an error message when a signer does not have the permissions needed to sign a proposal
- Updated the logic for when a xpub is available
- Updated logic for when a proposal can be finalized
- Updated logic for when a vault can be broadcasted
- Updated the logic for when a proposal can be broadcasted
- Updated the logic for when a proposal can be retrieved from the network
| @@ -279,7 +279,7 @@ pub mod pallet { | |||
| // transactions without it | |||
There was a problem hiding this comment.
GPT summary of 67d442 - 632f22:
- Changed the return type of
if !signer.can_sign()fromreturn;toreturn - Changed the return type of
if tx_res.is_err()indo_insert_descriptorsanddo_insert_psbtfromreturn Some(tx_res);toreturn Some(tx_res) - Added checks for signed payloads in
ocw_insert_descriptors,ocw_insert_psbts, andocw_finalize_psbtswithreturn InvalidTransaction::BadProof.into()if the payloads are not verified
| @@ -117,8 +117,8 @@ impl<T: Config> GroupMember<T> { | |||
| } | |||
There was a problem hiding this comment.
| @@ -341,7 +341,7 @@ pub mod pallet { | |||
|
|
|||
| @@ -43,10 +43,10 @@ pub struct ParentInfo<T: Config> { | |||
|
|
|||
| @@ -1606,8 +1606,8 @@ impl<T: Config> Pallet<T> { | |||
| DrawdownsInfo::<T>::get(drawdown_id).ok_or(Error::<T>::DrawdownNotFound)?; | |||
There was a problem hiding this comment.
GPT summary of 5ad228 - 5faf71:
- Ensured that drawdown and revenue types are supported for bulk upload.
- Checked that a user can only have one role and that an admin role cannot be added.
- Ensured that investors can only be assigned to one project, developers to three, and contractors to five.
- Ensured that administrators have global scope and cannot be assigned to a project.
- Ensured that drawdowns, revenues, and revenue transactions are in the correct status for actions to be performed on them.
- Transferred funds from admin to user.
| @@ -376,8 +376,8 @@ fn get_drawdown_id( | |||
|
|
|||
There was a problem hiding this comment.
GPT summary of 51ad5c - c9d233:
- Modifications were made to the
get_drawdown_id(),get_transaction_id(),get_revenue_transaction_id(),expenditures_add_a_hard_cost_budget_expenditure_for_a_given_project_works(),expenditures_add_a_softcost_budget_expenditure_for_a_given_project_works(),expenditures_add_an_operational_budget_expenditure_for_a_given_project_works(),expenditures_add_an_others_budget_expenditure_for_a_given_project_works(),expenditures_edit_a_given_expenditure_works(),expenditures_admnistrator_tries_to_update_a_non_existent_expenditure_should_fail(), andexpenditures_delete_a_selected_expenditure_works()functions, which involved changes to the comparison logic and formatting of the code.
| @@ -176,7 +176,7 @@ impl<T: Config> Pallet<T> { | |||
| AccountOrApplication::Application(application_id) => <ApplicationsByAccount<T>>::iter() | |||
There was a problem hiding this comment.
GPT summary of ee3073 - f6924d:
- Fixed an issue with the
AccountOrApplication::Applicationfunction to return the correct account - Fixed an issue with the
MarketplaceRole::OwnerandMarketplaceRole::Adminfunctions to prevent admins from deleting themselves - Fixed an issue with the
create_offerfunction to ensure the price is valid - Fixed an issue with the
create_offerfunction to ensure the holder of NFT is in the same marketplace as the caller making the offer - Fixed an issue with the
approve_applicationfunction to prevent applications that are still pending or have already been approved from being approved again - Fixed an issue with the
enlist_sell_offerfunction to ensure the owner is in the marketplace - Fixed an issue with the
redeem_itemfunction to ensure the collection exists
| @@ -238,8 +238,8 @@ fn apply_to_marketplace_works() { | |||
| )); | |||
There was a problem hiding this comment.
GPT summary of e159b7 - e88400:
- Updated the logic for the
apply_to_marketplaceandapply_with_custodianfunctions - Updated the logic for the
remove_marketplacefunction to delete the storage from theapplicants_by_marketplacefor all application statuses (Pending, Approved, and Rejected) - Updated the logic for the
remove_marketplacefunction to delete the storage from theapplications_by_accountandapplications
| @@ -150,21 +150,21 @@ impl<T: Config<I>, I: 'static> Pallet<T, I> { | |||
| None => return DepositConsequence::UnknownAsset, | |||
There was a problem hiding this comment.
GPT summary of e9ffaf - 98f0c4:
- Added checks for overflow when increasing or decreasing the supply of an asset
- Added checks for when the minimum balance of an asset is not met
- Added checks for when an account does not have sufficient funds
- Added checks for when an account is frozen
- Added checks for when an asset is frozen
- Added checks for when an account or asset is removed
- Added checks for when an approval is destroyed
- Added checks for when an admin does not have permission
| @@ -42,7 +42,7 @@ impl<T: Config<I>, I: 'static> StoredMap<(T::AssetId, T::AccountId), T::Extra> f | |||
| if let Some(ref mut account) = maybe_account { | |||
| @@ -1159,7 +1159,7 @@ pub mod pallet { | |||
| ensure!(details.status == AssetStatus::Live, Error::<T, I>::LiveAsset); | |||
| @@ -123,7 +123,7 @@ pub enum ExistenceReason<Balance> { | |||
| impl<Balance> ExistenceReason<Balance> { | |||
|
GPT summary of c71011f: Error: couldn't generate summary |
|
GPT summary of 90c5ad4:
PR summary so far:
|
🔧 chore(mock.rs): remove unused code and update runtime configuration to improve code cleanliness and maintainability
…tion ✨ feat(functions.rs): add support for process.env.PORT environment variable to be able to run app on a configurable port 🔨 refactor(lib.rs): update Moment type to use BlockNumberFor<Self> instead of Self::BlockNumber to improve compatibility and scalability 🔥 chore(lib.rs): comment out unused type RemoveOrigin to improve code readability
| @@ -9,7 +9,6 @@ use sp_runtime::{ | |||
| testing::Header, | |||
There was a problem hiding this comment.
GPT summary of afee51 - eabfa5:
- Removed type
UncheckedExtrinsic - Changed type
BlockfromHeadertoMockBlock - Changed type
BlockfromBlocktoMockBlock - Changed type
NodeBlockfromBlocktoMockBlock - Changed type
UncheckedExtrinsicfromMockUncheckedExtrinsicto() - Changed type
HeaderfromHeadertoBlock
| @@ -13,17 +13,13 @@ use sp_runtime::{ | |||
| traits::{BlakeTwo256, Extrinsic as ExtrinsicT, IdentifyAccount, IdentityLookup, Verify}, | |||
| @@ -8,15 +8,11 @@ use sp_runtime::{ | |||
| traits::{BlakeTwo256, IdentityLookup}, | |||
| @@ -62,7 +62,7 @@ impl<T: Config> Pallet<T> { | |||
| ) -> AttributeValue<T> { | |||
There was a problem hiding this comment.
GPT summary of 140932 - a8e637:
- Changed the
attributefunction to convert the attribute to aBoundedVecand handle errors when converting - Changed the
collection_existsandinstance_existsfunctions to returntrueif the collection/instance exists - Changed the
create_fruniquefunction to convert theNextFruniqueto anItemIdand handle errors when minting - Changed the
do_nft_divisionfunction to clone the collection argument - Changed the
redeemfunction to clone the collection argument
| @@ -8,14 +8,10 @@ use sp_runtime::{ | |||
| traits::{BlakeTwo256, IdentityLookup}, | |||
| @@ -7,16 +7,12 @@ use sp_runtime::{ | |||
| traits::{BlakeTwo256, IdentityLookup}, | |||
| @@ -7,16 +7,12 @@ use sp_runtime::{ | |||
| traits::{BlakeTwo256, IdentityLookup}, | |||
There was a problem hiding this comment.
GPT summary of 0b699c - 5a583e:
- Changed the type of
UncheckedExtrinsicfromframe_system::mocking::MockUncheckedExtrinsic<Test>toframe_system::mocking::MockBlock<Test> - Changed the type of
Blockfromframe_system::mocking::MockBlock<Test>toframe_system::mocking::MockBlock<Test> - Removed the type of
NodeBlock - Changed the type of
HeaderfromHeadertoBlock - Added a type of
BlockHashCount
| @@ -37,12 +37,20 @@ pub mod pallet { | |||
|
|
|||
| @@ -11,7 +11,6 @@ use sp_runtime::{ | |||
| }; | |||
There was a problem hiding this comment.
GPT summary of 788ebb - dc9351:
- Changed the type of
Balancetou128 - Removed
UncheckedExtrinsictype - Updated
Blocktype toframe_system::mocking::MockBlock<Test> - Updated
Systempallet to includeConfig,Storage, andEvent<T> - Updated
GatedMarketplacepallet to includeStorageandEvent<T> - Updated
Configto includeHashing,AccountId,Lookup,Block,RuntimeEvent,BlockHashCount, andVersion
| @@ -33,14 +33,10 @@ use sp_runtime::{ | |||
| traits::{BlakeTwo256, IdentityLookup}, | |||
There was a problem hiding this comment.
| @@ -7,15 +7,11 @@ use sp_runtime::{ | |||
| testing::Header, | |||
|
GPT summary of d5a7d32: Error: couldn't generate summary |
|
GPT summary of e5bfaa6:
PR summary so far:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary so far: