-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/bump v1.3.0 #25
Conversation
… the Rust toolchain configuration
…onstraint for better compatibility
…5-22 channel 🔧 fix(rust-toolchain.toml): specify the exact nightly channel version to ensure consistent build environment
…For<Self> instead of Self::BlockNumber for better compatibility and flexibility
🔺 chore(pallets/afloat): update codec version to 3.6.1 🔺 chore(pallets/bitcoin-vaults): update codec version to 3.6.1 🔺 chore(pallets/confidential-docs): update codec version to 3.6.1 🔺 chore(pallets/fruniques): update codec version to 3.6.1 🔺 chore(pallets/fund-admin-records): update codec version to 3.6.1 🔺 chore(pallets/fund-admin): update codec version to 3.6.1 🔺 chore(pallets/gated-marketplace): update codec version to 3.6.1 🔺 chore(pallets/mapped-assets): update codec version to 3.6.1 and log version to 0.4.17 🔺 chore(pallets/rbac): update codec version to 3.6.1 🔺 chore(pallets/afloat): update scale-info version to 2.5.0 🔺 chore(pallets/bitcoin-vaults): update scale-info version to 2.5.0 🔺 chore(pallets/confidential-docs): update scale-info version to 2.5.0 🔺 chore(pallets/fruniques): update scale-info version to 2.5.0 🔺 chore(pallets/fund-admin-records): update scale-info version to 2.5.0 🔺 chore(pallets/fund-admin): update scale-info version to 2.5.0 🔺 chore(pallets/gated-marketplace): update scale-info version to 2.5.0 🔺 chore(pallets/mapped-assets): update scale-info version to 2.5.0 🔺 chore(pallets/rbac): update scale-info version to 2.5.0 📦 chore(Cargo.toml): update dependencies versions 🔺 deps(Cargo.toml): update codec to version 3.6.1 🔺 deps(Cargo.toml): update log to version 0.4.14 🔺 deps(Cargo.toml): update scale-info to version 2.5.0 🔺 deps(Cargo.toml): update frame-support to use polkadot-v1.0.0 branch
…ersions 🐛 fix(mapped-assets): import missing sp_io::hashing::blake2_256 in functions.rs ✨ feat(mapped-assets): add AfloatRole enum and related functions in types.rs
…ility and performance 🐛 fix(functions.rs): fix cloning of class_id variable to prevent ownership issues ✨ feat(functions.rs): add support for creating frunique collections with configurable owner and admin roles 🐛 fix(functions.rs): fix cloning of collection variable to prevent ownership issues
…e-support, frame-system, sp-core, sp-io, sp-runtime, sp-std to improve compatibility and stability 🔧 fix(functions.rs): import BlockNumberFor from frame_system::pallet_prelude to fix compilation error 🔧 fix(lib.rs): update weight for ocw_insert_descriptors, ocw_insert_psbts, ocw_finalize_psbts to improve performance and resource usage
🔍 chore(.gitignore): add /pallets/fund-admin/scripts directory to be ignored by git
…n order to enable default values for its fields
* Mapped assets pallet DebitFlags struct is private to the crate, so the debitFlags parameter from the afloat_do_burn method was removed and the debitFlags created internally, finally updated the afloat pallet accordingly. AssetId type is no longer Copy, so called the clone method where necessary. CollectionId type is no longer Copy, so called the clone method where necessary. JSON NumberValue struct has a new negative field, so this field was added as necesary. GenesisBuild has been deprecated, so the BitcoinVaults and MappedAssets pallets to use the new BuildGenesisConfig trait. Updated the block_number parameter type to be BlockNumberFor. Added does_asset_exist method to the MappedAssets pallet. Updated the way of checking overflow in the MappedAssets pallet to use checked_add. Added back the Rbac type to the MappedAssets pallet. * The where clause of the enum when contructing a mock runtime has been deprecated, so this clause was removed for all pallet mocks.Nonce and Block types have been added to the system::Config, and the Index, BlockNumber and Header types have been removed, so all pallet implementations for the Test runtime have been updated accordingly. FreezeIdentifier, MaxFreezes, RuntimeHoldReason and MaxHolds types have been added for the balances pallet, so the test runtimes for pallets that use the balances pallet have been added accordingly. The GenesisConfig is now generic over the runtime, so the test build_storage for all pallets have been updated accordingly, also this is now behind the BuildStorage trait so it has been imported where required. The UnknownAsset error of the mapped assets pallet has been updated to be Unknown, so updated some of the tests accordingly. The tokens BalanceConversion trait has been replaced by ConversionToAssetBalance, so updated the mapped assets test pallet accordingly.
… usage 🐛 fix(mock.rs): change ExistentialDeposit type from ConstU128<100> to ConstU64<1> to set a lower minimum balance requirement 🐛 fix(mock.rs): remove MaxReserves configuration to use default value 🐛 fix(mock.rs): remove MaxFreezes configuration to use default value ✨ feat(mock.rs): add Result return type to created and destroyed functions in AssetsCallback trait implementation
…ser_info_edit_works, update_other_user_info_by_not_admin_fails, update_other_user_info_by_admin_works, update_user_info_delete_works, set_afloat_balance_works, set_balance_by_other_than_owner_fails to match changes in the struct definition ✨ feat(tests.rs): add support for new struct field names in sign_up_works, update_user_info_edit_works, update_other_user_info_by_not_admin_fails, update_other_user_info_by_admin_works, update_user_info_delete_works, set_afloat_balance_works, set_balance_by_other_than_owner_fails to improve code readability and maintainability 🔨 refactor(tests.rs): update test functions to use new struct field names for SignUpArgs
…iable to improve code readability
…adability 🔧 chore(lib.rs): refactor default value for bdk_services_url in GenesisConfig to use a hardcoded value instead of cloning the input value
…dk_services_url.clone() for improved code readability and maintainability
…from frame support, so had to add it directly as a dependency on the pallets, and update all imports accordingly. sp-std is no longer exported from frame support, so had to add it directly as a dependency on the pallets, and update all imports accordingly. The balance transfer method is exposed through the token Mutate trait so had to import it, and update the call to transfer with the correct parameters. DispatchError is no longer exported from frame support so had to import it directly from sp_runtime. The https://github.com/paritytech/substrate repository has been archived, so updated all dependencies to use the new repo https://github.com/paritytech/substrate
…it to mocks of all pallets.
…o be 0. Removed the migration from the mapped assets pallet as the pallet was created after the migration code.
…allet storage version.
@@ -27,7 +27,7 @@ version = "0.21.0" | |||
source = "registry+https://github.com/rust-lang/crates.io-index" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -25,7 +25,7 @@ frame-benchmarking = { git = "https://github.com/paritytech/polkadot-sdk", tag = | |||
sp-runtime = { git = "https://github.com/paritytech/polkadot-sdk", tag = "v1.3.0-rc1", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPT summary of e344d4 - a36bc6:
- The version of the
pallet-timestamp
dependency was updated fromv1.3.0-rc1
to4.0.0-dev
- The version of the
pallet-fruniques
dependency was updated from0.1.0-dev
- The version of the
pallet-rbac
dependency was updated from4.0.0-dev
- The version of the
pallet-gated-marketplace
dependency was updated from4.0.0-dev
@@ -1,6 +1,6 @@ | |||
use super::*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPT summary of d4b906 - 6a0c05:
- Updated the imports to use the pallet_prelude crate
- Replaced the usage of the UnixTime trait with the get_timestamp_in_milliseconds method from the pallet_gated_marketplace pallet
- Added the cid_creator, group, created_by, created_date, last_modified_by, and last_modified_date fields to the UserInfo struct
- Updated the give_role_to_user method to take in the cid_creator and group fields
- Updated the cancel_offer method to set the cancellation_date field to the current timestamp and set the status to cancelled
@@ -15,11 +15,12 @@ pub mod types; | |||
pub mod pallet { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -68,7 +68,6 @@ impl system::Config for Test { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -12,6 +12,7 @@ mod tests; | |||
// mod benchmarking; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,68 @@ | |||
use crate::{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Added use statements for crate, frame_support, and sp_runtime.
- Added storage aliases for FruniqueCnt, FruniqueParent, and FruniqueChild.
- Added MigrateToV1 struct and OnRuntimeUpgrade implementation.
- If version is < 1, clear FruniqueParent and FruniqueChild storage items, set version to 1, and log.
- Otherwise log that upgrade wasn't run.
@@ -1162,7 +1162,7 @@ impl<T: Config> Pallet<T> { | |||
Ok(()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -246,7 +246,7 @@ pub(crate) fn new_test_ext() -> sp_io::TestExternalities { | |||
config.assimilate_storage(&mut storage).unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPT summary of 21370f5: Error: couldn't generate summary |
GPT summary of de38b35:
|
GPT summary of c796692:
|
GPT summary of 6ac39b0:
|
GPT summary of 9dfef1d: Error: couldn't generate summary |
GPT summary of d384a53: Error: couldn't generate summary |
GPT summary of 17d6130:
|
GPT summary of 5e443de: Error: couldn't generate summary |
GPT summary of 711e290:
|
GPT summary of 8dc111c:
|
GPT summary of 64f1f0d:
|
GPT summary of b05e7bf: Error: couldn't generate summary |
GPT summary of ddc4779: Error: couldn't generate summary |
GPT summary of d61dc78:
|
GPT summary of 1970cf8: Error: couldn't generate summary |
GPT summary of 13d45c2: Error: couldn't generate summary |
GPT summary of d19802d:
|
No description provided.