Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add delete Roles on kill storage #28

Merged
merged 2 commits into from
Dec 19, 2023
Merged

add delete Roles on kill storage #28

merged 2 commits into from
Dec 19, 2023

Conversation

tlacloc
Copy link
Contributor

@tlacloc tlacloc commented Dec 19, 2023

No description provided.

@tlacloc tlacloc self-assigned this Dec 19, 2023
github-actions[bot]
github-actions bot reviewed Dec 19, 2023
View reviewed changes
pallets/afloat/src/functions.rs
@@ -957,6 +957,7 @@ impl<T: Config> Pallet<T> {
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPT summary of 6a0c05 - fc976d:

  • Added a call to Rbac::remove_pallet_storage at the end of the Pallet::uninstall function.

@github-actions GitHub Actions
Copy link

GPT summary of cb5f262:

PR summary so far:

  • Removed pallet storage from the 'Pallet' module.
  • Updated the Pallet::uninstall function to include a call to Rbac::remove_pallet_storage.

github-actions[bot]
github-actions bot reviewed Dec 19, 2023
View reviewed changes
pallets/rbac/src/lib.rs
@@ -315,5 +315,16 @@ pub mod pallet {
Self::do_remove_permission_from_pallet(pallet, permission_id)?;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPT summary of d8dcfd - 04c864:

  • Added a new call index 6 for the remove_pallet_permissions function
  • Added weight to the remove_pallet_permissions function
  • Added a check to ensure that the origin is authorized for the remove_pallet_permissions function
  • Added functionality to the remove_pallet_permissions function to remove pallet storage

@github-actions GitHub Actions
Copy link

GPT summary of a35edbe:

  • Added a call index for remove_pallet_permissions lib.rs
  • Added weight for remove_pallet_permissions lib.rs
  • Added origin check for remove_pallet_permissions lib.rs
  • Added logic for remove_pallet_permissions lib.rs

PR summary so far:

  • Removed pallet storage from the Pallet::uninstall function
  • Added a new call index, weight, origin check, and functionality for the remove_pallet_permissions function

@tlacloc tlacloc merged commit 5cc43e4 into main Dec 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@sebastianmontero sebastianmontero sebastianmontero approved these changes

Assignees

@tlacloc tlacloc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tlacloc @sebastianmontero