Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pallet records/sources by drawdown #40

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

didiermis
Copy link
Contributor

No description provided.

…unused helper function `make_default_record_collection` and `make_array_record_collection`. This increases readability and maintainability of tests, as redundant or unused code segments are removed.

- Extended the `TableType` enum in the types for the Fund Admin Records pallet with two new types: `Rebalance` and `DrawdownSources`, representing additional categories for record tables. Also enriched the `RecordType` enum with the `BankDocumentation` variant. This makes the types more comprehensive, and capable of capturing wider kinds of data and records tailored to business needs.
@didiermis didiermis self-assigned this Feb 16, 2024
@@ -25,28 +25,6 @@ fn make_record_collection(
record_collection

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPT summary of 39f0b8 - 00589e:
Error: couldn't generate summary

@@ -27,6 +27,8 @@ pub enum TableType {
RecoveryDrawdown,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPT summary of 5335e9 - 1a494c:
Error: couldn't generate summary

Copy link

GPT summary of ff3a9d7:

Error: couldn't generate summary

Copy link

GPT summary of fb8c7fa:

Error: couldn't generate summary

PR summary so far:

Error: couldn't generate summary

Copy link
Contributor

@tlacloc tlacloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebastianmontero sebastianmontero merged commit 85702b9 into main Feb 16, 2024
1 of 2 checks passed
@tlacloc tlacloc deleted the feature/pallet-records/sources-by-drawdown branch February 16, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants