-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/pallet records/sources by drawdown #40
Feature/pallet records/sources by drawdown #40
Conversation
…unused helper function `make_default_record_collection` and `make_array_record_collection`. This increases readability and maintainability of tests, as redundant or unused code segments are removed. - Extended the `TableType` enum in the types for the Fund Admin Records pallet with two new types: `Rebalance` and `DrawdownSources`, representing additional categories for record tables. Also enriched the `RecordType` enum with the `BankDocumentation` variant. This makes the types more comprehensive, and capable of capturing wider kinds of data and records tailored to business needs.
@@ -25,28 +25,6 @@ fn make_record_collection( | |||
record_collection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -27,6 +27,8 @@ pub enum TableType { | |||
RecoveryDrawdown, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPT summary of ff3a9d7: Error: couldn't generate summary |
GPT summary of fb8c7fa: Error: couldn't generate summary PR summary so far: Error: couldn't generate summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.