Developed benchmarks and weights for afloat, closes #36 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Dreyhh
commented
Apr 1, 2024
Dreyhh
commented
- Developed benchmarks and weights for afloat pallet.
- Changed Fruniques's Attributes type to a BoundedVec.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sebastianmontero
requested changes
Apr 2, 2024
…trinsics from: rbac, gated_marketplace and fruniques
|
GPT summary of 57901a7: Error: couldn't generate summary |
|
GPT summary of 9667bcc: Error: couldn't generate summary PR summary so far: Error: couldn't generate summary |
|
GPT summary of 7f9cf81: Error: couldn't generate summary PR summary so far: Error: couldn't generate summary |
…action benchmark, replaced unwraps with assert_ok for calls to helpers functions that dont return a value in afloat benchmarks
|
GPT summary of bd05e7f: Error: couldn't generate summary PR summary so far: Error: couldn't generate summary |
|
@sebastianmontero aun no actualizo los weights, lo hare cuando tenga luz verde con los benchmarks |
sebastianmontero
requested changes
Apr 5, 2024
…orageMaps values for Fruniques and GM, fixed set_gm_do_enlist_sell_offer_worst_case(), updated do_create_sell/buy_order() methods signature to return the created offer_id given that there was no other way to reliably get the offer_id, updated gm's offer_id creation to include also the item_id, removed unused variables and imports
| @@ -32,7 +32,7 @@ gcloud-md5-ingress.yml | |||
| .secrets | |||
| @@ -0,0 +1,727 @@ | |||
| #![cfg(feature = "runtime-benchmarks")] | |||
| @@ -11,9 +11,9 @@ use pallet_rbac::types::{IdOrVec, RoleBasedAccessControl, RoleId}; | |||
| use scale_info::prelude::vec; | |||
| @@ -9,7 +9,6 @@ use sp_runtime::{ | |||
| traits::{BlakeTwo256, IdentityLookup}, | |||
| @@ -350,9 +350,14 @@ impl<T: Config> Pallet<T> { | |||
| Self::get_timestamp_in_milliseconds().ok_or(Error::<T>::TimestampError)?; | |||
|
GPT summary of a4ac3ae: Error: couldn't generate summary PR summary so far: Error: couldn't generate summary |
sebastianmontero
approved these changes
Apr 9, 2024
|
@sebastianmontero no habia generado los weigths actualizados con los ultimos cambios, esperaba confirmacion con benchmarks, abrire otra PR para incluirlos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.