Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Block Acknowledgement from BN to CN #519

Open
Tracked by #170
AlfredoG87 opened this issue Jan 22, 2025 · 0 comments · May be fixed by #518
Open
Tracked by #170

Add support for Block Acknowledgement from BN to CN #519

AlfredoG87 opened this issue Jan 22, 2025 · 0 comments · May be fixed by #518
Assignees
Labels
Block Node Issues/PR related to the Block Node. New Feature A new feature, service, or documentation. Major changes that are not backwards compatible.
Milestone

Comments

@AlfredoG87
Copy link
Contributor

AlfredoG87 commented Jan 22, 2025

Currently we are replying the CN with an items_ack, when we receive the block_proof, however we should be returning just a Block Ack once we receive the block_proof but also finish sucessful persistence and verification.

Otherwise BN should return a corresponding Error Message.

  1. When CN sends the expected block

    1. Return a PublishStreamResponse
      1. of BlockAcknowledgement with
        1. block_number = received, persisted and verified block number
        2. block_root_hash = block_hash of the received block
        3. block_already_exists = false
  2. When CN sends the expected block but fails VERIFICATION

    1. Return a PublishStreamResponse
      1. of EndOfStream with
        1. PublishStreamResponseCode status = STREAM_ITEMS_BAD_STATE_PROOF
        2. block_number = block_number that failed verification
@AlfredoG87 AlfredoG87 self-assigned this Jan 22, 2025
@AlfredoG87 AlfredoG87 added Block Node Issues/PR related to the Block Node. New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. labels Jan 22, 2025
@AlfredoG87 AlfredoG87 added this to the 0.4.0 milestone Jan 22, 2025
@AlfredoG87 AlfredoG87 linked a pull request Jan 22, 2025 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Block Node Issues/PR related to the Block Node. New Feature A new feature, service, or documentation. Major changes that are not backwards compatible.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant